sharp: add types for jp2() that is used for jpeg 2000 output#59678
sharp: add types for jp2() that is used for jpeg 2000 output#59678typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom HeartLab:sharp/add-jpeg-2000
Conversation
|
@richard-viney Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59678,
"author": "richard-viney",
"headCommitOid": "2ab227aa6840c3a9468fe27853c03cc6d43075e0",
"mergeBaseOid": "71d3ff0beb8fc71ccd056e9b29edff569c4d242a",
"lastPushDate": "2022-04-04T02:52:39.000Z",
"lastActivityDate": "2022-04-04T06:24:30.000Z",
"mergeOfferDate": "2022-04-04T05:26:24.000Z",
"mergeRequestDate": "2022-04-04T06:24:30.000Z",
"mergeRequestUser": "richard-viney",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "sharp",
"kind": "edit",
"files": [
{
"path": "types/sharp/index.d.ts",
"kind": "definition"
},
{
"path": "types/sharp/sharp-tests.ts",
"kind": "test"
}
],
"owners": [
"wooseopkim",
"BTOdell",
"JamieWoodbury",
"Fdebijl",
"billykwok",
"rexxars"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rexxars",
"date": "2022-04-04T05:25:44.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1087057685,
"ciResult": "pass"
} |
|
🔔 @wooseopkim @BTOdell @JamieWoodbury @fdebijl @billykwok @rexxars — please review this PR in the next few days. Be sure to explicitly select |
|
@richard-viney: Everything looks good here. I am ready to merge this PR (at 2ab227a) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@wooseopkim, @BTOdell, @JamieWoodbury, @fdebijl, @billykwok, @rexxars: you can do this too.) |
|
Ready to merge
…On Mon, 4 Apr 2022 at 5:26 PM, TypeScript Bot ***@***.***> wrote:
@richard-viney <https://github.com/richard-viney>: Everything looks good
here. I am ready to merge this PR (at 2ab227a
<2ab227a>)
on your behalf whenever you think it's ready.
If you'd like that to happen, please post a comment saying:
Ready to merge
and I'll merge this PR almost instantly. Thanks for helping out! ❤️
***@***.*** <https://github.com/wooseopkim>, @BTOdell
<https://github.com/BTOdell>, @JamieWoodbury
<https://github.com/JamieWoodbury>, @fdebijl <https://github.com/fdebijl>,
@billykwok <https://github.com/billykwok>, @rexxars
<https://github.com/rexxars>: you can do this too.)
—
Reply to this email directly, view it on GitHub
<#59678 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZYBTSLSZNGFGSL5VTRCDVDJ4Q3ANCNFSM5SOEKSKQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
npm test <package to test>.