[@mapbox/maki] Fix typings for Maki v7#59646
[@mapbox/maki] Fix typings for Maki v7#59646typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom mbullington:mapbox__maki__redo
Conversation
|
@mbullington Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59646,
"author": "mbullington",
"headCommitOid": "dc888acb54382fd228e681118004a798556d8279",
"mergeBaseOid": "d4f7c07666c2cfc5437995378b09730658e9a941",
"lastPushDate": "2022-04-01T16:22:50.000Z",
"lastActivityDate": "2022-04-01T19:43:48.000Z",
"mergeOfferDate": "2022-04-01T19:37:50.000Z",
"mergeRequestDate": "2022-04-01T19:43:48.000Z",
"mergeRequestUser": "mbullington",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "mapbox__maki",
"kind": "edit",
"files": [
{
"path": "types/mapbox__maki/index.d.ts",
"kind": "definition"
},
{
"path": "types/mapbox__maki/mapbox__maki-tests.ts",
"kind": "test"
}
],
"owners": [
"peterblazejewicz"
],
"addedOwners": [
"mbullington"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2022-04-01T19:37:10.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1086124416,
"ciResult": "pass"
} |
|
🔔 @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
peterblazejewicz
left a comment
There was a problem hiding this comment.
LGTM!
@mbullington thx a lot!
|
@mbullington: Everything looks good here. I am ready to merge this PR (at dc888ac) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@peterblazejewicz: you can do this too.) |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition: