Add comments to @ckeditor/ckeditor5-ui binding methods#59643
Add comments to @ckeditor/ckeditor5-ui binding methods#59643typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
bad9801 to
e7de865
Compare
e7de865 to
0c533bd
Compare
|
|
||
| enableCssTransitions?(): void; | ||
| disableCssTransitions?(): void; | ||
|
|
There was a problem hiding this comment.
It would be great if I could do
declare module "../view" {
class View {
enableCssTransitions(): void;
disableCssTransitions(): void;
}
}from injectcsstransitiondisabler.d.ts since these methods are only added if this latter is imported.
|
@fedemp Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59643,
"author": "fedemp",
"headCommitOid": "0c533bd61f26ddcd91056796a098465766d84950",
"mergeBaseOid": "85c07a9c3a998368ad51fc460bff628c90b49806",
"lastPushDate": "2022-04-01T15:08:11.000Z",
"lastActivityDate": "2022-04-02T23:28:05.000Z",
"mergeOfferDate": "2022-04-02T21:48:54.000Z",
"mergeRequestDate": "2022-04-02T23:28:05.000Z",
"mergeRequestUser": "fedemp",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "ckeditor__ckeditor5-ui",
"kind": "edit",
"files": [
{
"path": "types/ckeditor__ckeditor5-ui/ckeditor__ckeditor5-ui-tests.ts",
"kind": "test"
},
{
"path": "types/ckeditor__ckeditor5-ui/src/bindings/clickoutsidehandler.d.ts",
"kind": "definition"
},
{
"path": "types/ckeditor__ckeditor5-ui/src/bindings/injectcsstransitiondisabler.d.ts",
"kind": "definition"
},
{
"path": "types/ckeditor__ckeditor5-ui/src/bindings/preventdefault.d.ts",
"kind": "definition"
},
{
"path": "types/ckeditor__ckeditor5-ui/src/bindings/submithandler.d.ts",
"kind": "definition"
},
{
"path": "types/ckeditor__ckeditor5-ui/src/view.d.ts",
"kind": "definition"
}
],
"owners": [
"fedemp"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2022-04-02T21:48:15.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1086025033,
"ciResult": "pass"
} |
|
🔔 @fedemp — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@fedemp: Everything looks good here. I am ready to merge this PR (at 0c533bd) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition: