Bug-fix and more specfiic types for node-dijkstra#59638
Bug-fix and more specfiic types for node-dijkstra#59638typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom warerebel:master
Conversation
Provided types for 'path' function return Added type assertions to test
|
@warerebel Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59638,
"author": "warerebel",
"headCommitOid": "d0ef4464ae3152c23f04ec2d7921b2d75aa095a8",
"mergeBaseOid": "6f6a01bcead16fd97dd57c135163a7b37eb2b37f",
"lastPushDate": "2022-04-01T08:32:50.000Z",
"lastActivityDate": "2022-04-01T10:24:47.000Z",
"mergeOfferDate": "2022-04-01T10:13:31.000Z",
"mergeRequestDate": "2022-04-01T10:24:47.000Z",
"mergeRequestUser": "warerebel",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "node-dijkstra",
"kind": "edit",
"files": [
{
"path": "types/node-dijkstra/index.d.ts",
"kind": "definition"
},
{
"path": "types/node-dijkstra/node-dijkstra-tests.ts",
"kind": "test"
}
],
"owners": [
"nokutu"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "nokutu",
"date": "2022-04-01T10:12:50.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1085625503,
"ciResult": "pass"
} |
|
🔔 @nokutu — please review this PR in the next few days. Be sure to explicitly select |
|
@warerebel: Everything looks good here. I am ready to merge this PR (at d0ef446) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@nokutu: you can do this too.) |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
Example code demonstrates that Graph constructor does not accept an array input and is linted as incorrect type when called with the correct signature.
Changes made to index.d.ts to accept correct types on Graph constructor:
{[key: string]: {[key: string]: number}} | Map<string, Map<string, number>>
Added type assertions to the tests.