[intercom-web] Add support for custom attributes#59633
[intercom-web] Add support for custom attributes#59633typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
String, number, boolean, and null values are accepted as custom user attributes in `boot` and `update` calls. Intercom doc: https://www.intercom.com/help/en/articles/179-send-custom-user-attributes-to-intercom
|
@cdoe Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59633,
"author": "cdoe",
"headCommitOid": "45cedf554477667f8c6562ac1259504e126e024a",
"mergeBaseOid": "28dd788301a2cbfe0ee27c389b2962056fdddde6",
"lastPushDate": "2022-03-31T21:34:44.000Z",
"lastActivityDate": "2022-04-01T08:56:33.000Z",
"mergeOfferDate": "2022-04-01T08:49:55.000Z",
"mergeRequestDate": "2022-04-01T08:56:33.000Z",
"mergeRequestUser": "onatm",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "intercom-web",
"kind": "edit",
"files": [
{
"path": "types/intercom-web/index.d.ts",
"kind": "definition"
},
{
"path": "types/intercom-web/intercom-web-tests.ts",
"kind": "test"
}
],
"owners": [
"fongandrew",
"salbahra",
"onatm"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "onatm",
"date": "2022-04-01T08:49:15.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1085148398,
"ciResult": "pass"
} |
|
🔔 @fongandrew @salbahra @onatm — please review this PR in the next few days. Be sure to explicitly select |
|
@cdoe: Everything looks good here. I am ready to merge this PR (at 45cedf5) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@fongandrew, @salbahra, @onatm: you can do this too.) |
|
Ready to merge |
String, number, boolean, and null values are accepted as custom user attributes in
bootandupdatecalls. Intercom doc: https://www.intercom.com/help/en/articles/179-send-custom-user-attributes-to-intercomPlease fill in this template.
npm test <package to test>.If changing an existing definition: