🎉 'twemoji' no longer required#59628
Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom Mar 31, 2022
Merged
Conversation
Fixes in `package.json` from 13.1.1 allowed to properly use internal definitions: https://github.com/twitter/twemoji/releases/tag/v13.1.1 Thanks!
Contributor
|
@peterblazejewicz Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 1 package in this PR (and infra files)
Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59628,
"author": "peterblazejewicz",
"headCommitOid": "15c10d80e670b01133ffe2d37c4ffe3d3c3f3941",
"mergeBaseOid": "e11ae5d76bb7c11e606ed5aa0e47c1f1e81fd88d",
"lastPushDate": "2022-03-31T19:26:15.000Z",
"lastActivityDate": "2022-03-31T23:42:55.000Z",
"mergeOfferDate": "2022-03-31T22:12:56.000Z",
"mergeRequestDate": "2022-03-31T22:17:03.000Z",
"mergeRequestUser": "davwheat",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "twemoji",
"kind": "delete",
"files": [
{
"path": "types/twemoji/index.d.ts",
"kind": "definition"
},
{
"path": "types/twemoji/test/twemoji-tests.common-js.ts",
"kind": "test"
},
{
"path": "types/twemoji/test/twemoji-tests.global.ts",
"kind": "test"
},
{
"path": "types/twemoji/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/twemoji/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"coderbyheart",
"peterblazejewicz",
"davwheat"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2022-03-31T22:12:17.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "davwheat",
"date": "2022-03-31T19:33:37.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1085014266,
"ciResult": "pass"
} |
Contributor
|
🔔 @coderbyheart @davwheat — please review this PR in the next few days. Be sure to explicitly select |
davwheat
approved these changes
Mar 31, 2022
andrewbranch
approved these changes
Mar 31, 2022
Contributor
|
Ready to merge |
Member
Member
|
@typescript-bot I know it’s been a long day but when you tell someone they can self-merge you need to listen to them when they say they’re ready |
Contributor
|
The bot must have realised it's April Fools! |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes in
package.jsonfrom 13.1.1 allowed to properly use internaldefinitions:
https://github.com/twitter/twemoji/releases/tag/v13.1.1
Thanks!
notNeededPackages.json.