Skip to content

[ramda] Remove inactive ramda contributor#59624

Merged
andrewbranch merged 1 commit intoDefinitelyTyped:masterfrom
devrelm:devrelm/ramda-remove-devrelm
Mar 31, 2022
Merged

[ramda] Remove inactive ramda contributor#59624
andrewbranch merged 1 commit intoDefinitelyTyped:masterfrom
devrelm:devrelm/ramda-remove-devrelm

Conversation

@devrelm
Copy link
Copy Markdown
Contributor

@devrelm devrelm commented Mar 31, 2022

Just removing myself from the Ramda contributor list. I haven't contributed for a while and the notifications are getting noisy.

If changing an existing definition:

  • n/a Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • n/a If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 31, 2022

@devrelm Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 59624,
  "author": "devrelm",
  "headCommitOid": "684c420f8591a9d97ea7853319436418f45e7939",
  "mergeBaseOid": "d6b527de9f5bf07aa905597563ec1dc995f84ac1",
  "lastPushDate": "2022-03-31T15:38:03.000Z",
  "lastActivityDate": "2022-03-31T15:46:43.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "ramda",
      "kind": "edit",
      "files": [
        {
          "path": "types/ramda/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "TheHandsomeCoder",
        "donnut",
        "mdekrey",
        "sbking",
        "afharo",
        "teves-castro",
        "hojberg",
        "samsonkeung",
        "angeloocana",
        "raynerd",
        "moshensky",
        "ethanresnick",
        "deftomat",
        "blimusiek",
        "biern",
        "rayhaneh",
        "rgm",
        "drewwyatt",
        "jottenlips",
        "minitesh",
        "krantisinh",
        "nemo108",
        "jituanlin",
        "Philippe-mills",
        "Saul-Mirone",
        "Nicholaiii",
        "devrelm",
        "LORDBABUINO",
        "couzic",
        "NEWESTERS",
        "adispring",
        "essenmitsosse"
      ],
      "addedOwners": [],
      "deletedOwners": [
        "devrelm"
      ],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1084764483,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Edits Owners This PR adds or removes owners Popular package This PR affects a popular package (as counted by NPM download counts). Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Mar 31, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @TheHandsomeCoder @donnut @mdekrey @sbking @afharo @teves-castro @hojberg @samsonkeung @angeloocana @raynerd @moshensky @ethanresnick @deftomat @blimusiek @biern @rayhaneh @rgm @drewwyatt @jottenlips @minitesh @Krantisinh @Nemo108 @jituanlin @Philippe-mills @Saul-Mirone @Nicholaiii @LORDBABUINO @couzic @NEWESTERS @adispring @essenmitsosse — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link
Copy Markdown

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

ramda (unpkg)

was missing the following properties:

  1. collectBy
  2. modify
  3. modifyPath
  4. partialObject
  5. on
as well as these 5 other properties...

promap, sequence, splitWhenever, unwind, whereAny

Generated by 🚫 dangerJS against 684c420

@andrewbranch andrewbranch merged commit 06ac5d8 into DefinitelyTyped:master Mar 31, 2022
@devrelm devrelm deleted the devrelm/ramda-remove-devrelm branch March 31, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Edits Owners This PR adds or removes owners Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants