[ramda] Enable strict mode#59621
Conversation
|
@valerii15298 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59621,
"author": "valerii15298",
"headCommitOid": "d2dba9239dc3c7391d4f22aa42ef6e5936d16d44",
"mergeBaseOid": "d6b527de9f5bf07aa905597563ec1dc995f84ac1",
"lastPushDate": "2022-03-31T11:37:15.000Z",
"lastActivityDate": "2022-03-31T18:27:16.000Z",
"mergeOfferDate": "2022-03-31T18:10:49.000Z",
"mergeRequestDate": "2022-03-31T18:27:16.000Z",
"mergeRequestUser": "valerii15298",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "ramda",
"kind": "edit",
"files": [
{
"path": "types/ramda/index.d.ts",
"kind": "definition"
},
{
"path": "types/ramda/test/construct-tests.ts",
"kind": "test"
},
{
"path": "types/ramda/test/constructN-tests.ts",
"kind": "test"
},
{
"path": "types/ramda/test/is-tests.ts",
"kind": "test"
},
{
"path": "types/ramda/test/toPairsIn-tests.ts",
"kind": "test"
},
{
"path": "types/ramda/tools.d.ts",
"kind": "definition"
},
{
"path": "types/ramda/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.strictNullChecks`, `compilerOptions.strictFunctionTypes`, `compilerOptions.noImplicitThis`, `compilerOptions.noImplicitAny`, `compilerOptions.strict`)"
}
],
"owners": [
"TheHandsomeCoder",
"donnut",
"mdekrey",
"sbking",
"afharo",
"teves-castro",
"hojberg",
"samsonkeung",
"angeloocana",
"raynerd",
"moshensky",
"ethanresnick",
"deftomat",
"blimusiek",
"biern",
"rayhaneh",
"rgm",
"drewwyatt",
"jottenlips",
"minitesh",
"krantisinh",
"nemo108",
"jituanlin",
"Philippe-mills",
"Saul-Mirone",
"Nicholaiii",
"devrelm",
"LORDBABUINO",
"couzic",
"NEWESTERS",
"adispring",
"essenmitsosse"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2022-03-31T18:10:09.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "adispring",
"date": "2022-03-31T12:24:19.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "essenmitsosse",
"date": "2022-03-31T11:49:15.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1084470805,
"ciResult": "pass"
} |
|
🔔 @TheHandsomeCoder @donnut @mdekrey @sbking @afharo @teves-castro @hojberg @samsonkeung @angeloocana @raynerd @moshensky @ethanresnick @deftomat @blimusiek @biern @rayhaneh @rgm @drewwyatt @jottenlips @minitesh @Krantisinh @Nemo108 @jituanlin @Philippe-mills @Saul-Mirone @Nicholaiii @devrelm @LORDBABUINO @couzic @NEWESTERS @adispring @essenmitsosse — please review this PR in the next few days. Be sure to explicitly select |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. ramda (unpkg)was missing the following properties:
as well as these 5 other properties...promap, sequence, splitWhenever, unwind, whereAny |
|
@valerii15298: Everything looks good here. I am ready to merge this PR (at d2dba92) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@TheHandsomeCoder, @donnut, @mdekrey, @sbking, @afharo, @teves-castro, @hojberg, @samsonkeung, @angeloocana, @raynerd, @moshensky, @ethanresnick, @deftomat, @blimusiek, @biern, @rayhaneh, @rgm, @drewwyatt, @jottenlips, @minitesh, @Krantisinh, @Nemo108, @jituanlin, @Philippe-mills, @Saul-Mirone, @Nicholaiii, @devrelm, @LORDBABUINO, @couzic, @NEWESTERS, @adispring, @essenmitsosse: you can do this too.) |
|
Ready to merge |
npm test <package to test>.