Skip to content

Fix comment for jasmine afterAll. #59615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 2 commits into from
Mar 31, 2022
Merged

Fix comment for jasmine afterAll. #59615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eed0b7a
Fix comment for jasmine `afterAll`.
64json Mar 30, 2022
152d1f0
Fix comment for `afterAll` in `jasmine/index.d.ts` as well.
64json Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/jasmine/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ declare function afterEach(action: jasmine.ImplementationCallback, timeout?: num
declare function beforeAll(action: jasmine.ImplementationCallback, timeout?: number): void;

/**
* Run some shared teardown once before all of the specs in the describe are run.
* Run some shared teardown once after all of the specs in the describe are run.
* Note: Be careful, sharing the teardown from a afterAll makes it easy to accidentally leak state between your specs so that they erroneously pass or fail.
* @param action Function that contains the code to teardown your specs.
* @param timeout Custom timeout for an async afterAll
Expand Down
2 changes: 1 addition & 1 deletion types/jasmine/v3/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ declare function afterEach(action: jasmine.ImplementationCallback, timeout?: num
declare function beforeAll(action: jasmine.ImplementationCallback, timeout?: number): void;

/**
* Run some shared teardown once before all of the specs in the describe are run.
* Run some shared teardown once after all of the specs in the describe are run.
* Note: Be careful, sharing the teardown from a afterAll makes it easy to accidentally leak state between your specs so that they erroneously pass or fail.
* @param action Function that contains the code to teardown your specs.
* @param timeout Custom timeout for an async afterAll
Expand Down