🎉 remove 'git-parse' after migration from Flow to TS#59614
🎉 remove 'git-parse' after migration from Flow to TS#59614typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
No longer need as of version 2.1.1: https://github.com/wayfair/git-parse/releases/tag/v2.1.1 https://unpkg.com/browse/git-parse@2.1.1/dist/index.d.ts Thanks!
|
@peterblazejewicz Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 1 package in this PR (and infra files)Code ReviewsThere aren't any other owners of this package, so a DT maintainer will review it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59614,
"author": "peterblazejewicz",
"headCommitOid": "b0f5c37b91d9acadf1286bd89efce060886e10c5",
"mergeBaseOid": "7b9a23bcaa85088bfa8fd0776392ef0b027b82f4",
"lastPushDate": "2022-03-30T21:08:23.000Z",
"lastActivityDate": "2022-03-31T18:22:24.000Z",
"mergeOfferDate": "2022-03-31T18:11:22.000Z",
"mergeRequestDate": "2022-03-31T18:22:24.000Z",
"mergeRequestUser": "peterblazejewicz",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "git-parse",
"kind": "delete",
"files": [
{
"path": "types/git-parse/git-parse-tests.ts",
"kind": "test"
},
{
"path": "types/git-parse/index.d.ts",
"kind": "definition"
},
{
"path": "types/git-parse/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/git-parse/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2022-03-31T18:10:43.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1083627568,
"ciResult": "pass"
} |
|
🔔 @peterblazejewicz — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@peterblazejewicz: Everything looks good here. I am ready to merge this PR (at b0f5c37) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge 💘 |
No longer need as of version 2.1.1:
https://github.com/wayfair/git-parse/releases/tag/v2.1.1
https://unpkg.com/browse/git-parse@2.1.1/dist/index.d.ts
Thanks!
notNeededPackages.json.