Web screens window placement#59592
Conversation
|
@WORMSS Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59592,
"author": "WORMSS",
"headCommitOid": "2a7068d8158041ea0732b731248026408d28744d",
"mergeBaseOid": "2694b730b2e7f640c119564c5de9b43e60ef624b",
"lastPushDate": "2022-03-31T18:20:46.000Z",
"lastActivityDate": "2022-03-31T18:28:30.000Z",
"mergeOfferDate": "2022-03-31T18:27:17.000Z",
"mergeRequestDate": "2022-03-31T18:28:30.000Z",
"mergeRequestUser": "WORMSS",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "webscreens-window-placement",
"kind": "add",
"files": [
{
"path": "types/webscreens-window-placement/index.d.ts",
"kind": "definition"
},
{
"path": "types/webscreens-window-placement/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/webscreens-window-placement/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/webscreens-window-placement/webscreens-window-placement-tests.ts",
"kind": "test"
}
],
"owners": [],
"addedOwners": [
"WORMSS"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2022-03-31T18:21:38.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1083193493,
"ciResult": "pass"
} |
|
🔔 @WORMSS — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
| { | ||
| "private": true, | ||
| "dependencies": { | ||
| "typescript": "^2.2.2" |
There was a problem hiding this comment.
It was what the definition I was using as a reference had. Typical, it seems to be the only one alphabetically close to my PR that had one and I just happened to pick it.. Removing now
|
@WORMSS One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@WORMSS: Everything looks good here. I am ready to merge this PR (at 2a7068d) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Please fill in this template.
There was no "package", this is future browser functionality.
npm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
If removing a declaration:
notNeededPackages.json.