Skip to content

Extend expected types for element prop from react-infinite-scroller #59584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 1 commit into from
Mar 31, 2022
Merged

Extend expected types for element prop from react-infinite-scroller #59584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/react-infinite-scroller/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ declare namespace InfiniteScroll {
* Name of the element that the component should render as.
* Defaults to 'div'.
*/
element?: string | undefined;
element?: React.ReactNode | string | undefined;
/**
* Whether there are more items to be loaded. Event listeners are removed if false.
* Defaults to false.
Expand Down
18 changes: 18 additions & 0 deletions types/react-infinite-scroller/react-infinite-scroller-tests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,24 @@ class Test3 extends React.Component {
}
}

const Test4Component = ({}) => <div></div>;
class Test4 extends React.Component {
inputRef = React.createRef<HTMLDivElement>();

render() {
return (
<div ref={this.inputRef}>
<InfiniteScroll
element={Test4Component}
loadMore={(page) => {}}
>
<span>Test 4</span>
</InfiniteScroll>
</div>
);
}
}

class InfiniteScrollOverride extends InfiniteScroll {
getParentElement(el: HTMLElement) {
if (document.getElementById("scroll-header")) {
Expand Down