[office-js] [office-js-preview] (Excel) Pulling latest type definitions from CDN#59562
Conversation
|
@alison-mk Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PR
Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59562,
"author": "alison-mk",
"headCommitOid": "b39454e86f47a5d632704a537a21f56ab3a6c957",
"mergeBaseOid": "06be14d99fb6e64263751f906f124a27b3b496f5",
"lastPushDate": "2022-03-30T21:32:11.000Z",
"lastActivityDate": "2022-03-31T18:23:21.000Z",
"mergeOfferDate": "2022-03-31T18:07:38.000Z",
"mergeRequestDate": "2022-03-31T18:23:21.000Z",
"mergeRequestUser": "alison-mk",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "office-js-preview",
"kind": "edit",
"files": [
{
"path": "types/office-js-preview/index.d.ts",
"kind": "definition"
}
],
"owners": [
"OfficeDev",
"Rick-Kirkham",
"AlexJerabek",
"ElizabethSamuel-MSFT",
"alison-mk",
"samantharamon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "office-js",
"kind": "edit",
"files": [
{
"path": "types/office-js/index.d.ts",
"kind": "definition"
}
],
"owners": [
"OfficeDev",
"Rick-Kirkham",
"AlexJerabek",
"ElizabethSamuel-MSFT",
"alison-mk",
"samantharamon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2022-03-31T18:06:49.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "AlexJerabek",
"date": "2022-03-30T21:47:54.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "ElizabethSamuel-MSFT",
"date": "2022-03-30T21:43:09.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1083646939,
"ciResult": "pass"
} |
|
Hey @alison-mk, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @OfficeDev @Rick-Kirkham @AlexJerabek @ElizabethSamuel-MSFT @samantharamon — please review this PR in the next few days. Be sure to explicitly select |
|
@alison-mk: Everything looks good here. I am ready to merge this PR (at b39454e) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
Release URL: https://appsforoffice.microsoft.com/lib/1.1/hosted/office.debug.js
Beta URL: https://appsforoffice.microsoft.com/lib/beta/hosted/office.debug.js