[happyguestmx__web-utilities] Provide types for @happyguestmx/web-utilities#59523
[happyguestmx__web-utilities] Provide types for @happyguestmx/web-utilities#59523andrewbranch merged 12 commits intoDefinitelyTyped:masterfrom
Conversation
[@happyguestmx/web-utilities] adding module & types
|
@HappyGuest Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59523,
"author": "HappyGuest",
"headCommitOid": "203da80a80172cc53cce8aec4cd3e3a0d4773da6",
"mergeBaseOid": "7442d1be1371abb6ec2956f4e6b94d547a8ba712",
"lastPushDate": "2022-03-30T23:13:16.000Z",
"lastActivityDate": "2022-03-31T18:23:18.000Z",
"mergeOfferDate": "2022-03-30T23:27:35.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "happyguestmx__web-utilities",
"kind": "add",
"files": [
{
"path": "types/happyguestmx__web-utilities/happyguestmx__web-utilities-tests.ts",
"kind": "test"
},
{
"path": "types/happyguestmx__web-utilities/index.d.ts",
"kind": "definition"
},
{
"path": "types/happyguestmx__web-utilities/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/happyguestmx__web-utilities/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"HappyGuest"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2022-03-30T23:26:57.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1081210912,
"ciResult": "pass"
} |
|
🔔 @HappyGuest — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@HappyGuest The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
[@happyguestmx/web-utilities] Remove lambda dependency
|
@HappyGuest The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@HappyGuest The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@HappyGuest The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@HappyGuest The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
| // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped | ||
|
|
||
| import { APIGatewayProxyEvent, APIGatewayProxyResult } from 'aws-lambda'; | ||
| declare module '@happyguestmx/web-utilities' { |
There was a problem hiding this comment.
There’s no need for this wrapper.
|
@HappyGuest One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@andrewbranch Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
andrewbranch
left a comment
There was a problem hiding this comment.
Looks good after removing package.json
| { | ||
| "private": true, | ||
| "dependencies": {} | ||
| } |
There was a problem hiding this comment.
Sorry I missed this, you can delete this file too.
|
@HappyGuest One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@andrewbranch Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
Ready to merge |
|
@typescript-bot we’re waiting |
|
Oh, @Alvarez-P you can’t be ready to merge because you’re not @HappyGuest |
|
Ready to merge |
ty |
Provide types for @happyguestmx/web-utilities
npm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.