@fedemp Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• ckeditor__ckeditor5-alignment — on npm, on unpkg (author is owner)

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 59462,
  "author": "fedemp",
  "headCommitOid": "42c289f56183d2e76fd184236b16d5447c886e22",
  "mergeBaseOid": "5645902043cb66286072976a5a46a2031aca6515",
  "lastPushDate": "2022-03-28T21:05:03.000Z",
  "lastActivityDate": "2022-03-31T21:48:35.000Z",
  "mergeOfferDate": "2022-03-31T19:34:53.000Z",
  "mergeRequestDate": "2022-03-31T21:48:35.000Z",
  "mergeRequestUser": "fedemp",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "ckeditor__ckeditor5-alignment",
      "kind": "edit",
      "files": [
        {
          "path": "types/ckeditor__ckeditor5-alignment/ckeditor__ckeditor5-alignment-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ckeditor__ckeditor5-alignment/src/alignmentcommand.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-alignment/src/alignmentediting.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-alignment/src/alignmentui.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "fedemp"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-03-31T19:34:14.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1079115911,
  "ciResult": "pass"
}

🔔 @fedemp — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

🔔 @denisname — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@fedemp The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@fedemp The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@fedemp The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@fedemp: Everything looks good here. I am ready to merge this PR (at 42c289f) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

Ready to merge