@userlerueda Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• dockerode — on npm, on unpkg (author is owner)
  • owner-approval: @thegecko

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 59416,
  "author": "userlerueda",
  "headCommitOid": "7732af96cedbcc709de8d721b8cf30a546566b6a",
  "mergeBaseOid": "87fed5c5355e4518db03253847a1ce0cd40c05db",
  "lastPushDate": "2022-03-26T12:28:40.000Z",
  "lastActivityDate": "2022-04-03T22:07:24.000Z",
  "mergeOfferDate": "2022-04-03T22:04:18.000Z",
  "mergeRequestDate": "2022-04-03T22:07:24.000Z",
  "mergeRequestUser": "userlerueda",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "dockerode",
      "kind": "edit",
      "files": [
        {
          "path": "types/dockerode/dockerode-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/dockerode/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "seikho",
        "nlaplante",
        "isac322",
        "lazarusx",
        "meisenzahl",
        "thegecko",
        "CameronDiver",
        "p4sca1",
        "stuartthomson",
        "userlerueda"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "thegecko",
      "date": "2022-04-03T22:03:38.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "MysteryBlokHed",
      "date": "2022-03-24T00:19:16.000Z",
      "abbrOid": "ef12bef"
    }
  ],
  "mainBotCommentID": 1076542841,
  "ciResult": "pass"
}

🔔 @Seikho @nlaplante @isac322 @LazarusX @meisenzahl @thegecko @CameronDiver @P4sca1 @stuartthomson — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@MysteryBlokHed Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

It looks like the PR still needs approval from either one of the other owners or a maintainer

@MysteryBlokHed Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@userlerueda The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@Seikho @nlaplante @isac322 @LazarusX @meisenzahl @thegecko @CameronDiver @P4sca1 @stuartthomson
Could one of you take a look at this PR? I'm not able to approve it since I'm not an owner and it's marked as a popular package.

@userlerueda: Everything looks good here. I am ready to merge this PR (at 7732af9) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Seikho, @nlaplante, @isac322, @LazarusX, @meisenzahl, @thegecko, @CameronDiver, @P4sca1, @stuartthomson: you can do this too.)

Ready to merge