[ramda] Add edge cases to aperture-tests#59386
[ramda] Add edge cases to aperture-tests#59386typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
|
@vzhou842 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59386,
"author": "vzhou842",
"headCommitOid": "c6ab78001e814d393a61de37759e038abe60b14f",
"mergeBaseOid": "7c426b274c9b13dfd781d6ff2f35812ede3e36d7",
"lastPushDate": "2022-03-31T18:29:44.000Z",
"lastActivityDate": "2022-03-31T18:50:00.000Z",
"mergeOfferDate": "2022-03-31T18:49:49.000Z",
"mergeRequestDate": "2022-03-31T18:50:00.000Z",
"mergeRequestUser": "vzhou842",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "ramda",
"kind": "edit",
"files": [
{
"path": "types/ramda/test/aperture-tests.ts",
"kind": "test"
}
],
"owners": [
"TheHandsomeCoder",
"donnut",
"mdekrey",
"sbking",
"afharo",
"teves-castro",
"hojberg",
"samsonkeung",
"angeloocana",
"raynerd",
"moshensky",
"ethanresnick",
"deftomat",
"blimusiek",
"biern",
"rayhaneh",
"rgm",
"drewwyatt",
"jottenlips",
"minitesh",
"krantisinh",
"nemo108",
"jituanlin",
"Philippe-mills",
"Saul-Mirone",
"Nicholaiii",
"devrelm",
"LORDBABUINO",
"couzic",
"NEWESTERS",
"adispring",
"essenmitsosse"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "essenmitsosse",
"date": "2022-03-31T18:49:10.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1074825713,
"ciResult": "pass"
} |
|
🔔 @TheHandsomeCoder @donnut @mdekrey @sbking @afharo @teves-castro @hojberg @samsonkeung @angeloocana @raynerd @moshensky @ethanresnick @deftomat @blimusiek @biern @rayhaneh @rgm @drewwyatt @jottenlips @minitesh @Krantisinh @Nemo108 @jituanlin @Philippe-mills @Saul-Mirone @Nicholaiii @devrelm @LORDBABUINO @couzic @NEWESTERS @adispring @essenmitsosse — please review this PR in the next few days. Be sure to explicitly select |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. ramda (unpkg)was missing the following properties:
as well as these 5 other properties...promap, sequence, splitWhenever, unwind, whereAny |
|
@vzhou842 Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
5aee503 to
a047b80
Compare
|
@vzhou842 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Co-authored-by: Marcus Blättermann <marcus@essenmitsosse.de>
|
@essenmitsosse Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.See #59384 - this PR adds edge case tests that would've caught the problems with the revised implementation proposed in that PR.