lru-cache Add @isaacs as an owner#59327
lru-cache Add @isaacs as an owner#59327typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@dhensby Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. InactiveThis PR has been inactive for 10 days — please merge or say something if there's a problem, otherwise it will be closed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59327,
"author": "dhensby",
"headCommitOid": "f1c2fdab4911a2bceff39eef60b5726d9a5d1177",
"mergeBaseOid": "53f3d10c2298739416109c7d9a2f6d003656d8f6",
"lastPushDate": "2022-03-17T23:19:37.000Z",
"lastActivityDate": "2022-03-28T16:19:04.000Z",
"mergeOfferDate": "2022-03-18T06:05:39.000Z",
"mergeRequestDate": "2022-03-28T16:19:04.000Z",
"mergeRequestUser": "dhensby",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "lru-cache",
"kind": "edit",
"files": [
{
"path": "types/lru-cache/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Bartvds",
"BendingBender"
],
"addedOwners": [
"isaacs"
],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gabritto",
"date": "2022-03-18T06:04:57.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1071807999,
"ciResult": "pass"
} |
|
Hey @dhensby, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @Bartvds @BendingBender — please review this PR in the next few days. Be sure to explicitly select |
|
@dhensby: Everything looks good here. I am ready to merge this PR (at f1c2fda) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@Bartvds, @BendingBender: you can do this too.) |
|
Before I merge this in, @isaacs can you confirm you're happy with this? Thanks |
|
Re-ping @dhensby / @Bartvds, @BendingBender: This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Apr 17th (in three weeks) if this doesn't happen. (If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.) |
|
Just waiting on confirmation that @isaacs is ok with this :) |
|
Fine by me. |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.The current owners (@BendingBender and @Bartvds) are not particularly active or responsive to PRs that get opened for these typings (no judgement on that note). @isaacs is the actual author of the npm module and has indicated they're happy to review typing contributions and help ensure they are accurate, but also that this remains a community driven initiative. As such, adding @isaacs as an owner gives them the ability to provide that oversight whilst sparing them the obligation of keeping the types up to date.