Skip to content

Add userlerueda to definition owners#59271

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
userlerueda:patch-3
Mar 17, 2022
Merged

Add userlerueda to definition owners#59271
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
userlerueda:patch-3

Conversation

@userlerueda
Copy link
Copy Markdown
Contributor

@userlerueda userlerueda commented Mar 14, 2022

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 14, 2022 •
edited
Loading

@userlerueda Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

@userlerueda: I see that you have added yourself as an owner, are you sure you want to become an owner?

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 59271,
  "author": "userlerueda",
  "headCommitOid": "c8eea0ccc1de6c39e7a798ac1505cd47dc5b9c14",
  "mergeBaseOid": "13b76775202f1eda53b9f92207fe5572d513f7fc",
  "lastPushDate": "2022-03-14T16:04:54.000Z",
  "lastActivityDate": "2022-03-17T02:00:38.000Z",
  "mergeOfferDate": "2022-03-17T01:02:18.000Z",
  "mergeRequestDate": "2022-03-17T02:00:38.000Z",
  "mergeRequestUser": "userlerueda",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "dockerode",
      "kind": "edit",
      "files": [
        {
          "path": "types/dockerode/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "seikho",
        "nlaplante",
        "isac322",
        "lazarusx",
        "meisenzahl",
        "thegecko",
        "CameronDiver",
        "p4sca1",
        "stuartthomson"
      ],
      "addedOwners": [
        "userlerueda"
      ],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gabritto",
      "date": "2022-03-17T01:01:38.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "P4sca1",
      "date": "2022-03-14T17:12:43.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "CameronDiver",
      "date": "2022-03-14T17:06:09.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1067002762,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Edits Owners This PR adds or removes owners Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Mar 14, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 14, 2022

Hey @userlerueda,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 14, 2022

🔔 @Seikho @nlaplante @isac322 @LazarusX @meisenzahl @thegecko @CameronDiver @P4sca1 @stuartthomson — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Mar 14, 2022
@userlerueda
Copy link
Copy Markdown
Contributor Author

userlerueda commented Mar 14, 2022

Thanks @CameronDiver and @P4sca1 !
The bot says only a DT maintainer can approve changes without tests.
Since this PR does not add any actual definitions, there are no tests. Not sure how to proceed with that.

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 17, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 17, 2022

@userlerueda: Everything looks good here. I am ready to merge this PR (at c8eea0c) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Seikho, @nlaplante, @isac322, @LazarusX, @meisenzahl, @thegecko, @CameronDiver, @P4sca1, @stuartthomson: you can do this too.)

@userlerueda
Copy link
Copy Markdown
Contributor Author

userlerueda commented Mar 17, 2022

Ready to merge

@typescript-bot typescript-bot merged commit b9d5a7d into DefinitelyTyped:master Mar 17, 2022
@userlerueda userlerueda deleted the patch-3 branch April 5, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabritto gabritto gabritto approved these changes

+2 more reviewers

@CameronDiver CameronDiver CameronDiver approved these changes

@P4sca1 P4sca1 P4sca1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Edits Owners This PR adds or removes owners Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@userlerueda @typescript-bot @CameronDiver @P4sca1 @gabritto