Skip to content

@types/chartmogul-node: Reflect API changes, remove unused parameter and function definition#59268

Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
chartmogul:master
Mar 17, 2022
Merged

@types/chartmogul-node: Reflect API changes, remove unused parameter and function definition#59268
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
chartmogul:master

Conversation

@sbrych
Copy link
Copy Markdown

@sbrych sbrych commented Mar 14, 2022

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: API auth documentation
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 14, 2022

@sbrych Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 59268,
  "author": "sbrych",
  "headCommitOid": "98e25192c9ee0ee0a27ef896d6df0d4081e93bbd",
  "mergeBaseOid": "13b76775202f1eda53b9f92207fe5572d513f7fc",
  "lastPushDate": "2022-03-14T12:29:32.000Z",
  "lastActivityDate": "2022-03-17T08:36:33.000Z",
  "mergeOfferDate": "2022-03-17T08:23:03.000Z",
  "mergeRequestDate": "2022-03-17T08:36:33.000Z",
  "mergeRequestUser": "sbrych",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "chartmogul-node",
      "kind": "edit",
      "files": [
        {
          "path": "types/chartmogul-node/chartmogul-node-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/chartmogul-node/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chartmogul"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "pkopac",
      "date": "2022-03-17T08:22:22.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1066735817,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @chartmogul — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link
Copy Markdown

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

chartmogul-node (unpkg)

was missing the following properties:

  1. Enrichment
  2. Import
  3. PlanGroup
  4. Account

Generated by 🚫 dangerJS against 98e2519

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 17, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@sbrych: Everything looks good here. I am ready to merge this PR (at 98e2519) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@chartmogul: you can do this too.)

@sbrych
Copy link
Copy Markdown
Author

sbrych commented Mar 17, 2022

Ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants