lru-cache 7.5 typings#59266
Conversation
|
@dhensby Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59266,
"author": "dhensby",
"headCommitOid": "7da316bef0b85ff21cfc27d24805213f089661b7",
"mergeBaseOid": "327fbf87c6f18c573a75a40acbdc3a3d2cde7bff",
"lastPushDate": "2022-03-14T09:51:51.000Z",
"lastActivityDate": "2022-03-17T20:12:30.000Z",
"mergeOfferDate": "2022-03-17T19:55:13.000Z",
"mergeRequestDate": "2022-03-17T20:12:30.000Z",
"mergeRequestUser": "dhensby",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "lru-cache",
"kind": "edit",
"files": [
{
"path": "types/lru-cache/index.d.ts",
"kind": "definition"
},
{
"path": "types/lru-cache/lru-cache-tests.ts",
"kind": "test"
}
],
"owners": [
"Bartvds",
"BendingBender"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gabritto",
"date": "2022-03-17T19:54:31.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1066582435,
"ciResult": "pass"
} |
|
🔔 @Bartvds @BendingBender — please review this PR in the next few days. Be sure to explicitly select |
gabritto
left a comment
There was a problem hiding this comment.
this seems good, but let's wait for owner reviews since it's a popular package. thanks
|
|
||
| declare class LRUCache<K, V> implements Iterable<[K, V]> { | ||
| constructor(options?: LRUCache.Options<K, V>); | ||
| constructor(options: LRUCache.Options<K, V>); |
There was a problem hiding this comment.
is options no longer optional starting at 7.5 or was it never optional and DT was wrong? I can't seem to find a change related to that on the original library (isaacs/node-lru-cache@v7.4.0...v7.5.0)
There was a problem hiding this comment.
It was never optional and the typings are wrong :(
See #59162
|
@gabritto unfortunately we aren't seeing much action from the designated code owners on this module (there have been several PRs now to these definitions without their feedback) |
|
@dhensby: Everything looks good here. I am ready to merge this PR (at 7da316b) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@Bartvds, @BendingBender: you can do this too.) |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition: