Added type definitions for react-payment-inputs#59262
Added type definitions for react-payment-inputs#59262typescript-bot merged 5 commits intoDefinitelyTyped:masterfrom
Conversation
|
@tyirenkyi Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59262,
"author": "tyirenkyi",
"headCommitOid": "e3598ff7cabdd4327b2a80cd82d3d483958b3c57",
"mergeBaseOid": "b44d932190b7ad49c9c6574380807b37fc5d032e",
"lastPushDate": "2022-03-15T22:03:38.000Z",
"lastActivityDate": "2022-03-16T00:42:11.000Z",
"mergeOfferDate": "2022-03-15T23:30:12.000Z",
"mergeRequestDate": "2022-03-16T00:42:11.000Z",
"mergeRequestUser": "tyirenkyi",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-payment-inputs",
"kind": "add",
"files": [
{
"path": "types/react-payment-inputs/images/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-payment-inputs/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-payment-inputs/react-payment-inputs-tests.tsx",
"kind": "test"
},
{
"path": "types/react-payment-inputs/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/react-payment-inputs/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"tyirenkyi"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2022-03-15T23:29:32.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1066303092,
"ciResult": "pass"
} |
|
🔔 @tyirenkyi — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@tyirenkyi The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
6f71932 to
51a12f7
Compare
peterblazejewicz
left a comment
There was a problem hiding this comment.
Please revert change to top level package.json.
Your changes should be limited to content within 'types/react-payment-inputs'
|
@tyirenkyi One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
peterblazejewicz
left a comment
There was a problem hiding this comment.
LGTM!
@tyirenkyi thx!
|
@tyirenkyi: Everything looks good here. I am ready to merge this PR (at e3598ff) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.