@alonstern Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• jsrsasign — on npm, on unpkg
  • owner-approval: @ffflorian

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 59257,
  "author": "alonstern",
  "headCommitOid": "ffb0f9e87095c220d6890a8b9f616595fd341e3f",
  "mergeBaseOid": "9b8c01776f02e44e4b2bf758d18abccbe9d71553",
  "lastPushDate": "2022-03-17T07:36:12.000Z",
  "lastActivityDate": "2022-03-17T20:28:04.000Z",
  "mergeOfferDate": "2022-03-17T20:02:12.000Z",
  "mergeRequestDate": "2022-03-17T20:28:04.000Z",
  "mergeRequestUser": "alonstern",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "jsrsasign",
      "kind": "edit",
      "files": [
        {
          "path": "types/jsrsasign/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/jsrsasign/modules/RSAKey.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ffflorian"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gabritto",
      "date": "2022-03-17T20:01:33.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "ffflorian",
      "date": "2022-03-17T09:31:55.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1066179616,
  "ciResult": "pass"
}

Hey @alonstern,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

🔔 @ffflorian — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

jsrsasign (unpkg)

was missing the following properties:

1. SecureRandom
2. rng_seed_time
3. ECDSA
4. DSA
5. Signature

Generated by 🚫 dangerJS against ffb0f9e

@alonstern One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

This change seems to have been made as of version 10.2 of the original library (kjur/jsrsasign@3f97051). However, those DT definitions are marked as for version 9.0 (first line of https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/jsrsasign/index.d.ts). Could you also update the version to 10.2 in that header, so that the definitions match the original library? Thanks.

Thanks @gabritto

@gabritto, @ffflorian Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@gabritto Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@alonstern: Everything looks good here. I am ready to merge this PR (at ffb0f9e) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ffflorian: you can do this too.)

Ready to merge