[Discussion#59192] Declaration export does not match the levelup package#59253
Conversation
|
@istherepie Thank you for submitting this PR! This is a live comment which I will keep updated. 4 packages in this PR
Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59253,
"author": "istherepie",
"headCommitOid": "bd8558802ff63806a00bf06606dc3735e0b96c04",
"mergeBaseOid": "13b76775202f1eda53b9f92207fe5572d513f7fc",
"lastPushDate": "2022-03-14T11:08:27.000Z",
"lastActivityDate": "2022-03-17T11:32:52.000Z",
"mergeOfferDate": "2022-03-16T21:46:32.000Z",
"mergeRequestDate": "2022-03-17T11:32:52.000Z",
"mergeRequestUser": "istherepie",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "level-ttl",
"kind": "edit",
"files": [
{
"path": "types/level-ttl/level-ttl-tests.ts",
"kind": "test"
}
],
"owners": [
"carsonfarmer"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "level",
"kind": "edit",
"files": [
{
"path": "types/level/index.d.ts",
"kind": "definition"
}
],
"owners": [
"danielfx90"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "levelup",
"kind": "edit",
"files": [
{
"path": "types/levelup/index.d.ts",
"kind": "definition"
},
{
"path": "types/levelup/levelup-tests.ts",
"kind": "test"
},
{
"path": "types/levelup/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"MeirionHughes",
"danwbyrne",
"carsonfarmer",
"istherepie"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "subleveldown",
"kind": "edit",
"files": [
{
"path": "types/subleveldown/subleveldown-tests.ts",
"kind": "test"
}
],
"owners": [
"carsonfarmer",
"demensky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gabritto",
"date": "2022-03-16T21:45:51.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "danielfx90",
"date": "2022-03-14T11:32:14.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1066142398,
"ciResult": "pass"
} |
|
🔔 @carsonfarmer @danielfx90 @MeirionHughes @danwbyrne @demensky — please review this PR in the next few days. Be sure to explicitly select |
|
I am not using LevelDB anymore, so I am a bit rusty with its usage. Are these changes needed for a newer version of LevelDB or were the type definitions wrong from the beginning? If the changes are needed for a newer version, let's add a comment in the type definitions. If they were wrong from the beginning, i'll approve them so that we can merge them ASAP. |
Specifically for the levelup wrapper the export has changed from earlier versions, In either case, it should change to match the current 5.x version of levelup, Line 333: module.exports = LevelUPLink: https://github.com/Level/levelup/blob/e73f536a46d7b8b2fa3d9b5abd0ae6efca41653e/lib/levelup.js#L333 |
71feb35 to
b75995b
Compare
The rule NeedsExportEquals was previously disabled. Due to this, we didn't notice that declaration export was broken.
b75995b to
bd85588
Compare
|
@istherepie: Everything looks good here. I am ready to merge this PR (at bd85588) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Please fill in this template.
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run
npm test <package to test>.Provide a URL to documentation or source code which provides context for the suggested changes: