Skip to content

[imapflow] fix #59239 // add missing prop#59242

Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
Grayson-code:master
Mar 16, 2022
Merged

[imapflow] fix #59239 // add missing prop#59242
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
Grayson-code:master

Conversation

@Grayson-code
Copy link
Copy Markdown
Contributor

Please fill in this template.

If changing an existing definition:

@Grayson-code Grayson-code changed the title [imapflow] fix 59239 // add missing prop [imapflow] fix #59239 // add missing prop Mar 12, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 12, 2022

@Grayson-code Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 59242,
  "author": "Grayson-code",
  "headCommitOid": "d027ba825d0f9adc4523349f70354dc7c36e191d",
  "mergeBaseOid": "35d90395c6f4d156aee74ad5654e072e5c6bf715",
  "lastPushDate": "2022-03-13T07:24:46.000Z",
  "lastActivityDate": "2022-03-16T07:35:34.000Z",
  "mergeOfferDate": "2022-03-15T22:08:03.000Z",
  "mergeRequestDate": "2022-03-16T07:35:34.000Z",
  "mergeRequestUser": "Grayson-code",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "imapflow",
      "kind": "edit",
      "files": [
        {
          "path": "types/imapflow/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jeffreyratton98",
        "martin-badin"
      ],
      "addedOwners": [
        "grayson-code"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gabritto",
      "date": "2022-03-15T22:07:24.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1065818438,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Edits Owners This PR adds or removes owners Untested Change This PR does not touch tests labels Mar 12, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

Hey @Grayson-code,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @jeffreyratton98 @martin-badin — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 15, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@Grayson-code: Everything looks good here. I am ready to merge this PR (at d027ba8) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jeffreyratton98, @martin-badin: you can do this too.)

@Grayson-code
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit e513b02 into DefinitelyTyped:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Edits Owners This PR adds or removes owners Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants