@rnitta Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• object-fit-images — on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 6 days.

{
  "type": "info",
  "now": "-",
  "pr_number": 59199,
  "author": "rnitta",
  "headCommitOid": "98fcec6d509ab2054f3c038256ba3281fb22c1ed",
  "mergeBaseOid": "4d36ebc9253e57b2f3117eea9af3cc18adc2a6ab",
  "lastPushDate": "2022-03-09T04:14:51.000Z",
  "lastActivityDate": "2022-04-04T02:19:52.000Z",
  "mergeOfferDate": "2022-03-28T23:25:02.000Z",
  "mergeRequestDate": "2022-04-04T02:19:52.000Z",
  "mergeRequestUser": "rnitta",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "object-fit-images",
      "kind": "edit",
      "files": [
        {
          "path": "types/object-fit-images/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/object-fit-images/object-fit-images-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "rann91"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2022-03-28T23:24:23.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1062536013,
  "ciResult": "pass"
}

🔔 @rann91 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

object-fit-images (unpkg)

was missing the following properties:

1. supportsObjectFit
2. supportsObjectPosition

Generated by 🚫 dangerJS against 98fcec6

Re-ping @rann91:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @rnitta.

(Ping @rann91.)

@rnitta: Everything looks good here. I am ready to merge this PR (at 98fcec6) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@rann91: you can do this too.)

Ready to merge