Skip to content

[mailchimp_marketing] Add types definition for updateListMemberTags#59136

Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
odanieldcs:mailchimp_marketing_api30
Mar 16, 2022
Merged

[mailchimp_marketing] Add types definition for updateListMemberTags#59136
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
odanieldcs:mailchimp_marketing_api30

Conversation

@odanieldcs
Copy link
Copy Markdown

@odanieldcs odanieldcs commented Mar 4, 2022

Just add support to type definitions for method lists.updateListMemberTags.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@odanieldcs odanieldcs marked this pull request as ready for review March 4, 2022 23:34
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 4, 2022 •
edited
Loading

@odanieldcs Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 59136,
  "author": "odanieldcs",
  "headCommitOid": "cc86af0b755aa2208e40d5dd3aedd1e5d32c61c5",
  "mergeBaseOid": "7d0f1ff2793123e18dc9b57573d4eca7ca643239",
  "lastPushDate": "2022-03-04T23:28:19.000Z",
  "lastActivityDate": "2022-03-16T14:13:47.000Z",
  "mergeOfferDate": "2022-03-16T05:43:00.000Z",
  "mergeRequestDate": "2022-03-16T14:13:47.000Z",
  "mergeRequestUser": "odanieldcs",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "mailchimp__mailchimp_marketing",
      "kind": "edit",
      "files": [
        {
          "path": "types/mailchimp__mailchimp_marketing/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mailchimp__mailchimp_marketing/mailchimp__mailchimp_marketing-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "rattkin",
        "jeremybarbet"
      ],
      "addedOwners": [
        "odanieldcs"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rattkin",
      "date": "2022-03-16T05:42:17.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1059605164,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Edits Owners This PR adds or removes owners label Mar 4, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 4, 2022

🔔 @rattkin @jeremybarbet — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Mar 16, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 16, 2022

Re-ping @rattkin, @jeremybarbet:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

rattkin
rattkin approved these changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@rattkin rattkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, on holiday!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Mar 16, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 16, 2022

@odanieldcs: Everything looks good here. I am ready to merge this PR (at cc86af0) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@rattkin, @jeremybarbet: you can do this too.)

@odanieldcs
Copy link
Copy Markdown
Author

odanieldcs commented Mar 16, 2022

Ready to merge

@typescript-bot typescript-bot merged commit e50156b into DefinitelyTyped:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rattkin rattkin rattkin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Edits Owners This PR adds or removes owners Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@odanieldcs @typescript-bot @rattkin