Conversation
|
question: should blocks with |
I could see a case to be made for either removing them all now or leaving them in place until they actually break. I don't have a strong opinion either way, so I'll defer to those of you who have more experience with DT. |
| seed: 4321, | ||
| oneFailurePerSpec: true, | ||
| failFast: true, | ||
| stopSpecOnExpectationFailure: true, |
There was a problem hiding this comment.
karma-jasmine just passes the provided config through to jasmine-core, so although the configuration changes affect karma-jasmine's users, they shouldn't affect karma-jasmine itself.
|
@sgravrock Thank you for submitting this PR! This is a live comment which I will keep updated. 3 packages in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59013,
"author": "sgravrock",
"headCommitOid": "c410f41da8b242c582fb7ae33a72df1a5f391e9f",
"mergeBaseOid": "7af8bea109c8225c06456291a7234eba8ccc5acb",
"lastPushDate": "2022-03-05T19:12:54.000Z",
"lastActivityDate": "2022-03-15T23:18:22.000Z",
"mergeOfferDate": "2022-03-15T21:16:28.000Z",
"mergeRequestDate": "2022-03-15T23:18:22.000Z",
"mergeRequestUser": "sgravrock",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "jasmine-ajax",
"kind": "edit",
"files": [
{
"path": "types/jasmine-ajax/jasmine-ajax-tests.ts",
"kind": "test"
}
],
"owners": [
"lgrignon",
"jgonggrijp"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "jasmine",
"kind": "edit",
"files": [
{
"path": "types/jasmine/index.d.ts",
"kind": "definition"
},
{
"path": "types/jasmine/jasmine-tests.ts",
"kind": "test"
},
{
"path": "types/jasmine/v3/index.d.ts",
"kind": "definition"
},
{
"path": "types/jasmine/v3/jasmine-tests.ts",
"kind": "test"
},
{
"path": "types/jasmine/v3/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.strictFunctionTypes`, `compilerOptions.esModuleInterop`)"
},
{
"path": "types/jasmine/v3/tslint.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
}
],
"owners": [
"borisyankov",
"theodorejb",
"davidparsson",
"lukas-zech-software",
"Engineer2B",
"cyungmann",
"Roaders",
"devoto13",
"fdim",
"kolodny",
"stephenfarrar",
"djungowski",
"chivesrs",
"kirjs",
"ienzam"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "karma-jasmine",
"kind": "edit",
"files": [
{
"path": "types/karma-jasmine/karma-jasmine-tests.ts",
"kind": "test"
}
],
"owners": [
"michelsalib",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gabritto",
"date": "2022-03-15T21:15:46.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "chivesrs",
"date": "2022-03-07T20:01:00.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1059818522,
"ciResult": "pass"
} |
|
🔔 @lgrignon @jgonggrijp @borisyankov @theodorejb @davidparsson @lukas-zech-software @Engineer2B @cyungmann @Roaders @devoto13 @FDIM @kolodny @stephenfarrar @djungowski @chivesrs @kirjs @ienzam @michelsalib @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
|
@sgravrock: Everything looks good here. I am ready to merge this PR (at c410f41) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
[√] Provide a URL to documentation or source code which provides context for the suggested changes: jasmine-core diff, jasmine diff, upgrade guide with links to release notes
[√] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.