Skip to content

@types/gtag.js - Add additional "get" callback types according to the API#58984

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
frantonlinsonos:master
Mar 16, 2022
Merged

@types/gtag.js - Add additional "get" callback types according to the API#58984
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
frantonlinsonos:master

Conversation

@frantonlinsonos
Copy link
Copy Markdown

@frantonlinsonos frantonlinsonos commented Feb 25, 2022

  • Added CustomParams and undefined types to the "get" command callback parameter. These types are possible according to the API documentation. The requested field may be CustomParams if getting user_properties
  • Updated tests and npm test gtag.js passes

If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Feb 25, 2022

@frantonlinsonos Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 58984,
  "author": "frantonlinsonos",
  "headCommitOid": "483394884f5109112899e144be6f43515e2fc39f",
  "mergeBaseOid": "a9d5996e671a28b53edf973dcd16dcbb0a4220b7",
  "lastPushDate": "2022-02-25T00:27:39.000Z",
  "lastActivityDate": "2022-03-16T17:12:28.000Z",
  "mergeOfferDate": "2022-03-15T21:43:43.000Z",
  "mergeRequestDate": "2022-03-16T17:12:28.000Z",
  "mergeRequestUser": "frantonlinsonos",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "gtag.js",
      "kind": "edit",
      "files": [
        {
          "path": "types/gtag.js/gtag.js-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/gtag.js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "rokt33r"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gabritto",
      "date": "2022-03-15T21:43:01.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1050397025,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Feb 25, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @Rokt33r — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Mar 8, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

Re-ping @Rokt33r:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot
Copy link
Copy Markdown
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @frantonlinsonos.

(Ping @Rokt33r.)

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Mar 15, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@frantonlinsonos: Everything looks good here. I am ready to merge this PR (at 4833948) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Rokt33r: you can do this too.)

@frantonlinsonos
Copy link
Copy Markdown
Author

Ready to merge

@typescript-bot typescript-bot merged commit aed7a8d into DefinitelyTyped:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants