Skip to content

[react-slider] Fix tests assuming instances in ref callbacks are non-nullable #58964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 1 commit into from
Mar 16, 2022
Merged

[react-slider] Fix tests assuming instances in ref callbacks are non-nullable #58964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions types/react-slider/react-slider-tests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class Slider extends React.Component<ReactSliderProps> {
trackClassName="classnameForBar"
withTracks={false}
marks={5}
renderMark={props => <span {...props} />}
renderMark={props => <div {...props} />}
{...this.props}
/>
);
Expand Down Expand Up @@ -40,12 +40,12 @@ function SingleThumbSliders() {
orientation="horizontal"
pageFn={step => step * 15}
pearling
renderMark={props => <span {...props} />}
renderMark={props => <div {...props} />}
renderThumb={(props, { index, value, valueNow }) => {
return <span {...props}>{index + valueNow + value}</span>;
return <div {...props}>{index + valueNow + value}</div>;
}}
renderTrack={(props, { index, value }) => {
return <span {...props}>{index + value}</span>;
return <div {...props}>{index + value}</div>;
}}
snapDragDisabled
step={2}
Expand Down Expand Up @@ -84,12 +84,12 @@ function MultipleThumbSliders() {
onBeforeChange={value => value.join()}
onChange={value => value.join()}
renderThumb={({ ref, ...props }, { value }) => (
<span ref={ref} {...props}>
<div ref={ref} {...props}>
{value.join()}
</span>
</div>
)}
renderTrack={(props, { value }) => {
return <span {...props}>{value.join()}</span>;
return <div {...props}>{value.join()}</div>;
}}
/>

Expand All @@ -116,7 +116,7 @@ interface CustomThumbProps extends React.HTMLProps<HTMLDivElement> {

const CustomThumb = React.forwardRef<HTMLDivElement, CustomThumbProps>((props, ref) => {
const { show, ...otherProps } = props;
return show ? <span ref={ref} {...otherProps} /> : null;
return show ? <div ref={ref} {...otherProps} /> : null;
});

function SliderWithCustomThumb() {
Expand Down