Skip to content

[gtag.js] update ConfigParams properties#58944

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
IngyuTae:gtag.js
Mar 15, 2022
Merged

[gtag.js] update ConfigParams properties#58944
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
IngyuTae:gtag.js

Conversation

@IngyuTae
Copy link
Copy Markdown
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Feb 24, 2022

@IngyuTae Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 58944,
  "author": "IngyuTae",
  "headCommitOid": "129eb832cde5ad3f1666d9f1d81faf91e540fb14",
  "mergeBaseOid": "ec2fd7f5892eb63d0b891ff445d0b60c11f94c90",
  "lastPushDate": "2022-02-24T02:49:47.000Z",
  "lastActivityDate": "2022-03-15T21:44:26.000Z",
  "mergeOfferDate": "2022-03-15T21:31:34.000Z",
  "mergeRequestDate": "2022-03-15T21:44:26.000Z",
  "mergeRequestUser": "IngyuTae",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "gtag.js",
      "kind": "edit",
      "files": [
        {
          "path": "types/gtag.js/gtag.js-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/gtag.js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "rokt33r"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gabritto",
      "date": "2022-03-15T21:30:54.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1049443680,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Feb 24, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @Rokt33r — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Copy Markdown
Contributor

Re-ping @Rokt33r:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Mar 7, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @IngyuTae.

(Ping @Rokt33r.)

Copy link
Copy Markdown
Contributor

@gabritto gabritto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Mar 15, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@IngyuTae: Everything looks good here. I am ready to merge this PR (at 129eb83) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Rokt33r: you can do this too.)

@IngyuTae
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit f1f42e8 into DefinitelyTyped:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants