fix (json-schema): support $defs keyword#58886
fix (json-schema): support $defs keyword#58886typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
- The definitions keyword has been changed to $defs - Old style "definitions" still supported though https://json-schema.org/draft/2020-12/json-schema-validation.html#rfc.appendix.A
|
@robatosan Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 2 packages in this PRCode ReviewsThis PR can be merged once it's reviewed. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 58886,
"author": "robatosan",
"headCommitOid": "fea40348e94df431241a437b6fc393904d8e06f7",
"mergeBaseOid": "369ecc516615fb782639bd4d707be43a01c90df4",
"lastPushDate": "2022-02-21T09:50:06.000Z",
"lastActivityDate": "2022-03-16T11:58:59.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"mergeOfferDate": "2022-03-11T22:46:47.000Z",
"mergeRequestDate": "2022-03-16T11:58:59.000Z",
"mergeRequestUser": "robatosan",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "conventional-changelog-config-spec",
"kind": "edit",
"files": [
{
"path": "types/conventional-changelog-config-spec/conventional-changelog-config-spec-tests.ts",
"kind": "test"
}
],
"owners": [
"JasonHK"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "json-schema",
"kind": "edit",
"files": [
{
"path": "types/json-schema/index.d.ts",
"kind": "definition"
},
{
"path": "types/json-schema/json-schema-tests.ts",
"kind": "test"
}
],
"owners": [
"bcherny",
"cyrilletuzi",
"lucianbuzzo",
"rolandjitsu",
"JasonHK"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "RyanCavanaugh",
"date": "2022-03-11T22:46:08.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1046634789,
"ciResult": "pass"
} |
|
🔔 @JasonHK @bcherny @cyrilletuzi @LucianBuzzo @rolandjitsu — please review this PR in the next few days. Be sure to explicitly select |
|
@robatosan The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@robatosan The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
7769186 to
fea4034
Compare
|
Re-ping @JasonHK, @bcherny, @cyrilletuzi, @LucianBuzzo, @rolandjitsu: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @robatosan. (Ping @JasonHK, @bcherny, @cyrilletuzi, @LucianBuzzo, @rolandjitsu.) |
|
Ready to merge |
|
This MR adds $ref to the wrong type - |
https://json-schema.org/draft/2020-12/json-schema-validation.html#rfc.appendix.A
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition: