Skip to content

Conversation

@SimonSchick
Copy link
Contributor

@SimonSchick SimonSchick commented Dec 11, 2021

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

Note

For the time being this only rolls over types and only really adds deprecations & dns changes, it doesn't quite change anything yet, I think this time we should progressively roll changes in (I will try to do this) to make reviews easier.

@SimonSchick SimonSchick marked this pull request as ready for review December 11, 2021 22:02
@peterblazejewicz
Copy link
Member

@SimonSchick remind me, when v12 will be removed/phased out (from DT that is)
For me looks OK (sooner, better, it's behind versioning), I'll ask DT folks to review this quickly

@sandersn sandersn merged commit cb87cee into DefinitelyTyped:master Dec 15, 2021
@SimonSchick
Copy link
Contributor Author

@peterblazejewicz see https://nodejs.org/en/about/releases/ so end of May? One could argue that maintenance shouldn't include type alterations since the API is stable but at the same time we can't really garauntee that our types are correct.

If you want to remove it early I won't try and stop you but keeping them doesn't seem like a huge liability either.

@SimonSchick SimonSchick deleted the feat/node-v17 branch December 15, 2021 23:31
@peterblazejewicz
Copy link
Member

let's be on safe side and remove with v18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants