Add typings for "gulp-ttf2woff2"#57152
Conversation
|
@xapdkop Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 57152,
"author": "xapdkop",
"headCommitOid": "88c89e058c4b48762ede17f0df45419cf91f80ed",
"lastPushDate": "2021-11-15T22:29:29.000Z",
"lastActivityDate": "2021-11-15T22:29:29.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "gulp-ttf2woff2",
"kind": "add",
"files": [
{
"path": "types/gulp-ttf2woff2/gulp-ttf2woff2-tests.ts",
"kind": "test"
},
{
"path": "types/gulp-ttf2woff2/index.d.ts",
"kind": "definition"
},
{
"path": "types/gulp-ttf2woff2/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/gulp-ttf2woff2/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/gulp-ttf2woff2/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"xapdkop"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 968351526,
"ciResult": "pass"
} |
|
🔔 @xapdkop — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@xapdkop The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@xapdkop The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
6abb030 to
88c89e0
Compare
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.