remove(alex): no longer needed#56658
Conversation
as of 10.0.0 types are now created and shipped and shipped with package itself: get-alex/alex@9.1.1...10.0.0 Thanks!
|
@peterblazejewicz Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 1 package in this PR (and infra files)Code ReviewsThere aren't any other owners of this package, so a DT maintainer will review it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 56658,
"author": "peterblazejewicz",
"headCommitOid": "d3c09acb6ba3761263a880b365685ed608a29797",
"lastPushDate": "2021-10-20T19:12:09.000Z",
"lastActivityDate": "2021-10-21T19:13:29.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "alex",
"kind": "delete",
"files": [
{
"path": "types/alex/alex-tests.ts",
"kind": "test"
},
{
"path": "types/alex/index.d.ts",
"kind": "definition"
},
{
"path": "types/alex/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/alex/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/alex/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jnv",
"date": "2021-10-20T22:04:58.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 947990886,
"ciResult": "pass"
} |
|
🔔 @peterblazejewicz — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
jnv
left a comment
There was a problem hiding this comment.
LGTM. I am not sure if there are any rules around that, but perhaps the vfile dependency could be removed from the allowlist? I think this was the only package with that dependency.
|
Yes, I can do this as well, thx for pointing this out! |
|
ace |
as of 10.0.0 types are now created and shipped and shipped with package
itself:
get-alex/alex@9.1.1...10.0.0
Thanks!