Skip to content

[react] Inline usage of deprecated React.Props #56416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
typescript-bot merged 2 commits into from
Oct 21, 2021
Merged

[react] Inline usage of deprecated React.Props #56416

typescript-bot merged 2 commits into from
Oct 21, 2021

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Oct 10, 2021

In preparation of #46691.

Not inlining key since that's a special prop that is never usable by implementations. The type is automtatically added by the JSX runtime.

@eps1lon eps1lon mentioned this pull request Oct 10, 2021
Closed
10 tasks
@eps1lon eps1lon marked this pull request as ready for review October 10, 2021 11:11
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 10, 2021 •
edited
Loading

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

28 packages in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 56416,
  "author": "eps1lon",
  "headCommitOid": "2206a347022183c49c8a2f713fea90040977aa0a",
  "lastPushDate": "2021-10-15T19:15:02.000Z",
  "lastActivityDate": "2021-10-21T22:35:42.000Z",
  "mergeOfferDate": "2021-10-21T22:33:21.000Z",
  "mergeRequestDate": "2021-10-21T22:35:42.000Z",
  "mergeRequestUser": "eps1lon",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "fixed-data-table",
      "kind": "edit",
      "files": [
        {
          "path": "types/fixed-data-table/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pepaar",
        "stephenjelfs"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "halogen",
      "kind": "edit",
      "files": [
        {
          "path": "types/halogen/test/clip-loader.tsx",
          "kind": "test"
        },
        {
          "path": "types/halogen/test/fade-loader.tsx",
          "kind": "test"
        },
        {
          "path": "types/halogen/test/pacman-loader.tsx",
          "kind": "test"
        },
        {
          "path": "types/halogen/test/rotate-loader.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "steller"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "halogenium",
      "kind": "edit",
      "files": [
        {
          "path": "types/halogenium/test/clip-loader.tsx",
          "kind": "test"
        },
        {
          "path": "types/halogenium/test/fade-loader.tsx",
          "kind": "test"
        },
        {
          "path": "types/halogenium/test/pacman-loader.tsx",
          "kind": "test"
        },
        {
          "path": "types/halogenium/test/rotate-loader.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "WeslleyNasRocha"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "material-ui",
      "kind": "edit",
      "files": [
        {
          "path": "types/material-ui/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ngbrown",
        "theigor",
        "alitaheri",
        "herrmanno",
        "DaIgeb",
        "allienna",
        "schlesingermatthias",
        "InsidersByte",
        "artyomsv",
        "dan-j",
        "minodisk",
        "samwalshnz",
        "reggino"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "rc-tooltip",
      "kind": "edit",
      "files": [
        {
          "path": "types/rc-tooltip/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "rhysd",
        "ahstro",
        "vsaarinen",
        "aigoncharov"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-big-calendar",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-big-calendar/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "piotrwitek",
        "paustint",
        "pikpok",
        "eps1lon",
        "strongpauly",
        "janb87",
        "ldthorne",
        "siavelis",
        "lksilva",
        "SergeyBelofost",
        "marknelissen",
        "KenneyE",
        "PaitoAnderson",
        "michalak111",
        "tomtom5152",
        "catruzz",
        "altruisticsoftware",
        "princefishthrower"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-bootstrap-table",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-bootstrap-table/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-bootstrap-table/v2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "flaub",
        "alelode",
        "UJosue10",
        "dawnmist",
        "Ogglas"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-bootstrap",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-bootstrap/lib/BreadcrumbItem.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-bootstrap/lib/OverlayTrigger.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "walkerburgin",
        "vsiao",
        "danilojrr",
        "Batbold-Gansukh",
        "octatone",
        "chengsieuly",
        "mretolaza",
        "katbusch",
        "vitosamson",
        "LKay",
        "aaronbeall",
        "jrakotoharisoa",
        "r3nya",
        "t49tran",
        "collingreen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-bytesize-icons",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-bytesize-icons/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "vslutov"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-codemirror",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-codemirror/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-codemirror/react-codemirror-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "velveret",
        "rudi-c"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-datagrid",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-datagrid/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "stephenjelfs"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-daterange-picker",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-daterange-picker/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "uncovertruth",
        "MartynasZilinskas",
        "donaldtf",
        "vladflorescu94",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-flex",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-flex/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pushplay"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-flexr",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-flexr/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pushplay"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-imageloader",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-imageloader/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "stephenjelfs"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-infinite",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-infinite/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "rhysd"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-list",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-list/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "buptyyf",
        "tomshen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-native-scrollable-tab-view",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-native-scrollable-tab-view/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "CaiHuan",
        "egorshulga",
        "ydostyle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-native-snap-carousel",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-native-snap-carousel/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jnbt",
        "j-fro",
        "gazaret",
        "GuillaumeAmat",
        "VitorLuizC",
        "egarrett94"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-portal",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-portal/v3/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "shuntksh",
        "HorusGoul"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-redux-i18n",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-redux-i18n/react-redux-i18n-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "clementdevos"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-router",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-router/v2/lib/IndexRedirect.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-router/v2/lib/IndexRoute.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-router/v2/lib/Redirect.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-router/v2/lib/Route.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-router/v2/lib/Router.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-router/v2/lib/RouterContext.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-router/v2/lib/applyRouterMiddleware.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "sergey-buturlakin",
        "mrk21",
        "vasek17",
        "ngbrown",
        "awendland",
        "KostyaEsmukov",
        "johnnyreilly",
        "LKay",
        "DovydasNavickas",
        "huy-nguyen",
        "grmiade",
        "DaIgeb",
        "egorshulga",
        "rraina",
        "t49tran",
        "8enSmith",
        "wezleytsai",
        "eps1lon",
        "HipsterBrown",
        "pawfa"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "react-scrollbar",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-scrollbar/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "stephenjelfs",
        "HugoCapocci"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-tagcloud",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-tagcloud/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "wassname"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-tagsinput",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-tagsinput/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mykter",
        "chardos"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-widgets",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-widgets/react-widgets-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "rogierschouten",
        "sanyatuning",
        "frodehansen2",
        "r3nya",
        "MBillemaz",
        "georg94",
        "tzarger",
        "vegtelenseg",
        "calebergh",
        "rmckeel",
        "jankalfus"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "reactcss",
      "kind": "edit",
      "files": [
        {
          "path": "types/reactcss/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chrisgervang",
        "LKay"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "rebass__grid",
      "kind": "edit",
      "files": [
        {
          "path": "types/rebass__grid/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "antonvasin",
        "vittorio",
        "lhache",
        "lavoaster",
        "autoric",
        "akameco"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2021-10-21T22:32:29.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 939463025,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 10, 2021

⚠️ There are too many reviewers for this PR change (116). Merging can only be handled by a DT maintainer.

People who would have been pinged pepaar stephenjelfs steller WeslleyNasRocha ngbrown theigor alitaheri herrmanno DaIgeb allienna schlesingermatthias InsidersByte artyomsv dan-j minodisk samwalshnz reggino rhysd ahstro vsaarinen aigoncharov piotrwitek paustint pikpok strongpauly janb87 ldthorne siavelis lksilva SergeyBelofost marknelissen KenneyE PaitoAnderson michalak111 tomtom5152 catruzz altruisticsoftware princefishthrower flaub alelode UJosue10 dawnmist Ogglas walkerburgin vsiao danilojrr Batbold-Gansukh octatone chengsieuly mretolaza katbusch vitosamson LKay aaronbeall jrakotoharisoa r3nya t49tran collingreen vslutov velveret rudi-c uncovertruth MartynasZilinskas donaldtf vladflorescu94 peterblazejewicz pushplay buptyyf tomshen CaiHuan egorshulga ydostyle jnbt j-fro gazaret GuillaumeAmat VitorLuizC egarrett94 shuntksh HorusGoul clementdevos sergey-buturlakin mrk21 vasek17 awendland KostyaEsmukov johnnyreilly DovydasNavickas huy-nguyen grmiade rraina 8enSmith wezleytsai HipsterBrown pawfa HugoCapocci wassname mykter chardos rogierschouten sanyatuning frodehansen2 MBillemaz georg94 tzarger vegtelenseg calebergh rmckeel jankalfus chrisgervang antonvasin vittorio lhache lavoaster autoric akameco

@typescript-bot typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Oct 15, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 15, 2021

@eps1lon Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@typescript-bot typescript-bot removed the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Oct 15, 2021
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 21, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 21, 2021

@eps1lon: Everything looks good here. I am ready to merge this PR (at 2206a34) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@eps1lon
Copy link
Collaborator Author

eps1lon commented Oct 21, 2021

Ready to merge

@typescript-bot typescript-bot merged commit ac6c1b6 into DefinitelyTyped:master Oct 21, 2021
@eps1lon eps1lon deleted the fix/no-usage/Props branch October 28, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbuckton rbuckton rbuckton approved these changes

@octatone octatone Awaiting requested review from octatone

@peterblazejewicz peterblazejewicz Awaiting requested review from peterblazejewicz

Assignees

No one assigned

Labels

Critical package Edits multiple packages Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner Too Many Owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eps1lon @typescript-bot @rbuckton