[react] Replace deprecated SFC with FC #56402

eps1lon · 2021-10-09T12:03:33Z

In preparation of #46691

typescript-bot · 2021-10-10T09:24:15Z

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

41 packages in this PR

agiledigital__mule-preview — on npm, on unpkg
create-subscription — on npm, on unpkg
emoji-mart — on npm, on unpkg
input-moment — on npm, on unpkg
material-ui — on npm, on unpkg
meteor — on npm, on unpkg
- owner-approval: @radekmie
react-adal — on npm, on unpkg
react-css-collapse — on npm, on unpkg
react-currency-formatter — on npm, on unpkg
react-daterange-picker — on npm, on unpkg
- owner-approval: @vladflorescu94, @peterblazejewicz
react-form — on npm, on unpkg
- owner-approval: @Toliak
react-google-maps-loader — on npm, on unpkg
react-google-places-suggest — on npm, on unpkg
react-google-recaptcha — on npm, on unpkg
react-infinite-calendar — on npm, on unpkg
react-jsonschema-form — on npm, on unpkg
react-keyboard-event-handler — on npm, on unpkg
react-loadable — on npm, on unpkg
react-measure — on npm, on unpkg
react-mentions — on npm, on unpkg
react-native-android-taskdescription — on npm, on unpkg
react-native-phone-input — on npm, on unpkg
react-native-photo-view — on npm, on unpkg
react-native-scrollable-tab-view — on npm, on unpkg
react-native-svg-charts — on npm, on unpkg
react-notifications-component — on npm, on unpkg
react-radio-group — on npm, on unpkg
react-router-native — on npm, on unpkg
react-router — on npm, on unpkg (author is owner)
react-svg-map — on npm, on unpkg
react-tag-autocomplete — on npm, on unpkg
react-truncate — on npm, on unpkg
react-vis — on npm, on unpkg
react-window — on npm, on unpkg
react-with-styles — on npm, on unpkg
reactcss — on npm, on unpkg
recharts — on npm, on unpkg
recompose — on npm, on unpkg
redux-form — on npm, on unpkg
styled-components — on npm, on unpkg (author is owner)
webscopeio__react-textarea-autocomplete — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ A DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 56402,
  "author": "eps1lon",
  "headCommitOid": "1df0d20c274291bd745d03ef56146862fa50ace3",
  "lastPushDate": "2021-10-09T12:05:12.000Z",
  "lastActivityDate": "2021-10-20T20:32:23.000Z",
  "mergeOfferDate": "2021-10-20T19:41:33.000Z",
  "mergeRequestDate": "2021-10-20T20:32:23.000Z",
  "mergeRequestUser": "eps1lon",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "agiledigital__mule-preview",
      "kind": "edit",
      "files": [
        {
          "path": "types/agiledigital__mule-preview/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "NoxHarmonium"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "create-subscription",
      "kind": "edit",
      "files": [
        {
          "path": "types/create-subscription/create-subscription-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "Asana",
        "vsiao"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "emoji-mart",
      "kind": "edit",
      "files": [
        {
          "path": "types/emoji-mart/dist-es/components/emoji/nimble-emoji.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Jessidhia",
        "Nicell",
        "elviswolcott",
        "seoyunho",
        "tarrencev"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "input-moment",
      "kind": "edit",
      "files": [
        {
          "path": "types/input-moment/input-moment-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "timia2109"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "material-ui",
      "kind": "edit",
      "files": [
        {
          "path": "types/material-ui/material-ui-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "ngbrown",
        "theigor",
        "alitaheri",
        "herrmanno",
        "DaIgeb",
        "allienna",
        "schlesingermatthias",
        "InsidersByte",
        "artyomsv",
        "dan-j",
        "minodisk",
        "samwalshnz",
        "reggino"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "meteor",
      "kind": "edit",
      "files": [
        {
          "path": "types/meteor/test/react-meteor-data-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "barbatus",
        "fullflavedave",
        "orefalo",
        "dagatsoin",
        "ardatan",
        "stefanholzapfel",
        "andrei-markeev",
        "lmachens",
        "gunn",
        "alesn",
        "perbergland",
        "nicu-chiciuc",
        "ebroder",
        "radekmie",
        "wadamek65",
        "MacRusher",
        "ToastHawaii"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-adal",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-adal/react-adal-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "dkorolev1"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-css-collapse",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-css-collapse/react-css-collapse-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "dford07"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-currency-formatter",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-currency-formatter/react-currency-formatter-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "pastushenkoy",
        "Jeka-Vasiliev"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-daterange-picker",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-daterange-picker/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-daterange-picker/react-daterange-picker-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "uncovertruth",
        "MartynasZilinskas",
        "donaldtf",
        "vladflorescu94",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-form",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-form/v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-form/v1/react-form-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "cameron-mcateer",
        "TiuSh",
        "Toliak"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-google-maps-loader",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-google-maps-loader/react-google-maps-loader-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "vasilysn"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-google-places-suggest",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-google-places-suggest/react-google-places-suggest-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "vasilysn"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-google-recaptcha",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-google-recaptcha/react-google-recaptcha-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-google-recaptcha/v0/react-google-recaptcha-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "KoalaHuman",
        "tomsturge",
        "MaxwellBo",
        "meirkl",
        "RohrerF",
        "mocantimoteidavid"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-infinite-calendar",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-infinite-calendar/react-infinite-calendar-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "christianchown"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-jsonschema-form",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-jsonschema-form/react-jsonschema-form-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "iamdanfox",
        "iplus26",
        "phbou72",
        "LucianBuzzo",
        "sthenault",
        "sbusch",
        "medfreeman",
        "saadtazi",
        "agustin107",
        "chanceaclark",
        "ogdentrod",
        "andrenguyener",
        "qingqishi",
        "JonathanSouthern"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-keyboard-event-handler",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-keyboard-event-handler/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jamiegluk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-loadable",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-loadable/test/imports/no-default.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-loadable/test/index.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "Jessidhia",
        "odensc",
        "ianks",
        "tlaziuk",
        "iMobs"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-measure",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-measure/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-measure/react-measure-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "asvetliakov",
        "marcfallows"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-mentions",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-mentions/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-mentions/react-mentions-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "activescott",
        "efedorenko"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-native-android-taskdescription",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-native-android-taskdescription/react-native-android-taskdescription-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "christianchown"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-native-phone-input",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-native-phone-input/react-native-phone-input-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "maael"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-native-photo-view",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-native-photo-view/react-native-photo-view-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "christianchown"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-native-scrollable-tab-view",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-native-scrollable-tab-view/react-native-scrollable-tab-view-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "CaiHuan",
        "egorshulga",
        "ydostyle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-native-svg-charts",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-native-svg-charts/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "krzysztof-miemiec"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-notifications-component",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-notifications-component/react-notifications-component-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "SarhadSalam",
        "aitorres"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-radio-group",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-radio-group/react-radio-group-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "jsonunger"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-router-native",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-router-native/react-router-native-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "ezintz",
        "fhelwanger"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-router",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-router/test/WithRouter.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/test/examples-from-react-router-website/Ambiguous.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/test/examples-from-react-router-website/Animation.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/test/examples-from-react-router-website/Auth.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/test/examples-from-react-router-website/Basic.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/test/examples-from-react-router-website/CustomLink.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/test/examples-from-react-router-website/ModalGallery.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/test/examples-from-react-router-website/NoMatch.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/test/examples-from-react-router-website/Params.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/test/examples-from-react-router-website/Recursive.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/test/examples-from-react-router-website/RouteConfig.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/test/examples-from-react-router-website/StaticRouter.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/ts4.0/test/WithRouter.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/ts4.0/test/examples-from-react-router-website/Ambiguous.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/ts4.0/test/examples-from-react-router-website/Animation.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/ts4.0/test/examples-from-react-router-website/Auth.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/ts4.0/test/examples-from-react-router-website/Basic.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/ts4.0/test/examples-from-react-router-website/CustomLink.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/ts4.0/test/examples-from-react-router-website/ModalGallery.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/ts4.0/test/examples-from-react-router-website/NoMatch.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/ts4.0/test/examples-from-react-router-website/Params.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/ts4.0/test/examples-from-react-router-website/Recursive.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/ts4.0/test/examples-from-react-router-website/RouteConfig.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/ts4.0/test/examples-from-react-router-website/StaticRouter.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-router/v3/react-router-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "sergey-buturlakin",
        "mrk21",
        "vasek17",
        "ngbrown",
        "awendland",
        "KostyaEsmukov",
        "johnnyreilly",
        "LKay",
        "DovydasNavickas",
        "huy-nguyen",
        "grmiade",
        "DaIgeb",
        "egorshulga",
        "rraina",
        "t49tran",
        "8enSmith",
        "wezleytsai",
        "eps1lon",
        "HipsterBrown",
        "pawfa"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "react-svg-map",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-svg-map/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "nickglazer"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-tag-autocomplete",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-tag-autocomplete/v5/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jlismore",
        "Rahul-Sagore",
        "MaxCilauro",
        "akondratsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-truncate",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-truncate/react-truncate-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "mattvperry"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-vis",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-vis/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Domino987"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-window",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-window/react-window-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "martynaskadisa",
        "heyimalex",
        "jgoz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-with-styles",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-with-styles/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mohsen1",
        "brieb",
        "lencioni"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "reactcss",
      "kind": "edit",
      "files": [
        {
          "path": "types/reactcss/reactcss-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "chrisgervang",
        "LKay"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "recharts",
      "kind": "edit",
      "files": [
        {
          "path": "types/recharts/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "in19farkt"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "recompose",
      "kind": "edit",
      "files": [
        {
          "path": "types/recompose/recompose-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "iskandersierra",
        "clayne11",
        "Pajn",
        "lucasterra",
        "brian-lives-outdoors",
        "TiuSh"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "redux-form",
      "kind": "edit",
      "files": [
        {
          "path": "types/redux-form/v6/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/redux-form/v6/redux-form-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "aikoven",
        "LKay",
        "bancek",
        "tehbi4",
        "huwmartin",
        "m-b-davis",
        "ethanresnick",
        "maddijoyce",
        "smifun",
        "mshaaban088",
        "esetnik",
        "mrsekut",
        "abemedia"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "styled-components",
      "kind": "edit",
      "files": [
        {
          "path": "types/styled-components/test/index.tsx",
          "kind": "test"
        },
        {
          "path": "types/styled-components/v3/styled-components-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "Igorbek",
        "Igmat",
        "lavoaster",
        "Jessidhia",
        "jkillian",
        "eps1lon",
        "flavordaaave",
        "wagerfield",
        "Lazyuki",
        "mgoszcz2",
        "danilofuchs",
        "lifeiscontent"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "webscopeio__react-textarea-autocomplete",
      "kind": "edit",
      "files": [
        {
          "path": "types/webscopeio__react-textarea-autocomplete/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "michauzo"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "vladflorescu94",
      "date": "2021-10-20T19:44:50.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2021-10-20T19:40:41.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "Toliak",
      "date": "2021-10-20T17:37:10.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "radekmie",
      "date": "2021-10-20T14:00:55.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 939438053,
  "ciResult": "pass"
}

typescript-bot · 2021-10-10T09:24:17Z

⚠️ There are too many reviewers for this PR change (151). Merging can only be handled by a DT maintainer.

People who would have been pinged

NoxHarmonium Asana vsiao Jessidhia Nicell elviswolcott seoyunho tarrencev timia2109 ngbrown theigor alitaheri herrmanno DaIgeb allienna schlesingermatthias InsidersByte artyomsv dan-j minodisk samwalshnz reggino barbatus fullflavedave orefalo dagatsoin ardatan stefanholzapfel andrei-markeev lmachens gunn alesn perbergland nicu-chiciuc ebroder radekmie wadamek65 MacRusher ToastHawaii dkorolev1 dford07 pastushenkoy Jeka-Vasiliev uncovertruth MartynasZilinskas donaldtf vladflorescu94 peterblazejewicz cameron-mcateer TiuSh Toliak vasilysn KoalaHuman tomsturge MaxwellBo meirkl RohrerF mocantimoteidavid christianchown iamdanfox iplus26 phbou72 LucianBuzzo sthenault sbusch medfreeman saadtazi agustin107 chanceaclark ogdentrod andrenguyener qingqishi JonathanSouthern jamiegluk odensc ianks tlaziuk iMobs asvetliakov marcfallows activescott efedorenko maael CaiHuan egorshulga ydostyle krzysztof-miemiec SarhadSalam aitorres jsonunger ezintz fhelwanger sergey-buturlakin mrk21 vasek17 awendland KostyaEsmukov johnnyreilly LKay DovydasNavickas huy-nguyen grmiade rraina t49tran 8enSmith wezleytsai HipsterBrown pawfa nickglazer jlismore Rahul-Sagore MaxCilauro akondratsky mattvperry Domino987 martynaskadisa heyimalex jgoz mohsen1 brieb lencioni chrisgervang in19farkt iskandersierra clayne11 Pajn lucasterra brian-lives-outdoors aikoven bancek tehbi4 huwmartin m-b-davis ethanresnick maddijoyce smifun mshaaban088 esetnik mrsekut abemedia Igorbek Igmat lavoaster jkillian flavordaaave wagerfield Lazyuki mgoszcz2 danilofuchs lifeiscontent michauzo

typescript-bot · 2021-10-20T13:09:04Z

Re-ping @NoxHarmonium, @Asana, @vsiao, @Jessidhia, @Nicell, @elviswolcott, @Seoyunho, @tarrencev, @timia2109, @ngbrown, @theigor, @alitaheri, @herrmanno, @DaIgeb, @allienna, @schlesingermatthias, @InsidersByte, @artyomsv, @dan-j, @minodisk, @samwalshnz, @Reggino, @barbatus, @fullflavedave, @orefalo, @dagatsoin, @ardatan, @stefanholzapfel, @andrei-markeev, @lmachens, @gunn, @alesn, @perbergland, @nicu-chiciuc, @ebroder, @wadamek65, @MacRusher, @ToastHawaii, @dkorolev1, @dford07, @pastushenkoy, @Jeka-Vasiliev, @uncovertruth, @MartynasZilinskas, @donaldtf, @vladflorescu94, @peterblazejewicz, @cameron-mcateer, @TiuSh, @vasilysn, @KoalaHuman, @tomsturge, @MaxwellBo, @meirkl, @RohrerF, @mocantimoteidavid, @christianchown, @iamdanfox, @iplus26, @phbou72, @LucianBuzzo, @sthenault, @sbusch, @medfreeman, @saadtazi, @agustin107, @chanceaclark, @ogdentrod, @andrenguyener, @qingqishi, @JonathanSouthern, @jamiegluk, @odensc, @ianks, @tlaziuk, @iMobs, @asvetliakov, @marcfallows, @activescott, @efedorenko, @maael, @CaiHuan, @egorshulga, @ydostyle, @krzysztof-miemiec, @SarhadSalam, @aitorres, @jsonunger, @ezintz, @fhelwanger, @sergey-buturlakin, @mrk21, @vasek17, @awendland, @KostyaEsmukov, @johnnyreilly, @LKay, @DovydasNavickas, @huy-nguyen, @grmiade, @rraina, @t49tran, @8enSmith, @wezleytsai, @HipsterBrown, @pawfa, @nickglazer, @jlismore, @Rahul-Sagore, @MaxCilauro, @akondratsky, @mattvperry, @Domino987, @martynaskadisa, @heyimalex, @jgoz, @mohsen1, @brieb, @lencioni, @chrisgervang, @in19farkt, @iskandersierra, @clayne11, @Pajn, @lucasterra, @brian-lives-outdoors, @aikoven, @bancek, @tehbi4, @huwmartin, @m-b-davis, @ethanresnick, @maddijoyce, @smifun, @mshaaban088, @esetnik, @mrsekut, @abemedia, @Igorbek, @Igmat, @lavoaster, @jkillian, @flavordaaave, @wagerfield, @Lazyuki, @mgoszcz2, @danilofuchs, @lifeiscontent, @michauzo:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

peterblazejewicz · 2021-10-20T18:54:50Z

@eppsilon if this is merged (as it looks OK), is there any scenario that is not covered here? (if someone complain, how to quickly recognize it could be related to this change), thx!

eps1lon · 2021-10-20T19:23:02Z

SFC is just an alias for FC so this shouldn't cause any breakage. I don't know how I could know any scenario that is not covered upfront.

(if someone complain, how to quickly recognize it could be related to this change),

Doesn't the types publisher associate new package releases with a PR? If a breakage is detected, and that breakage only occurs with a version associated with this PR, then the PR is bad an should be reverted. We can then exclude the broken package from this change and investigate it separately.

peterblazejewicz

LGTM!

typescript-bot · 2021-10-20T19:41:33Z

@eps1lon: Everything looks good here. I am ready to merge this PR (at 1df0d20) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

eps1lon · 2021-10-20T20:32:23Z

Ready to merge

[react] Replace deprecated SFC with FC

1df0d20

eps1lon force-pushed the fix/no-usage/SFC branch from 67de59c to 1df0d20 Compare October 9, 2021 12:05

eps1lon marked this pull request as ready for review October 10, 2021 09:23

eps1lon requested review from Igorbek, Jessidhia, johnnyreilly and peterblazejewicz as code owners October 10, 2021 09:23

eps1lon mentioned this pull request Oct 10, 2021

[RFC] React 18 and types-only breaking changes #46691

Closed

10 tasks

typescript-bot added Critical package Edits multiple packages Too Many Owners labels Oct 10, 2021

typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Oct 20, 2021

radekmie approved these changes Oct 20, 2021

View reviewed changes

Toliak approved these changes Oct 20, 2021

View reviewed changes

peterblazejewicz approved these changes Oct 20, 2021

View reviewed changes

typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Oct 20, 2021

vladflorescu approved these changes Oct 20, 2021

View reviewed changes

typescript-bot merged commit 8638abd into DefinitelyTyped:master Oct 21, 2021

eps1lon deleted the fix/no-usage/SFC branch October 21, 2021 06:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[react] Replace deprecated SFC with FC #56402

[react] Replace deprecated SFC with FC #56402

Uh oh!

eps1lon commented Oct 9, 2021

Uh oh!

typescript-bot commented Oct 10, 2021 •

edited

Loading

Uh oh!

typescript-bot commented Oct 10, 2021

Uh oh!

typescript-bot commented Oct 20, 2021 •

edited

Loading

Uh oh!

peterblazejewicz commented Oct 20, 2021 •

edited

Loading

Uh oh!

eps1lon commented Oct 20, 2021

Uh oh!

peterblazejewicz left a comment

Uh oh!

typescript-bot commented Oct 20, 2021

Uh oh!

eps1lon commented Oct 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[react] Replace deprecated SFC with FC #56402

[react] Replace deprecated SFC with FC #56402

Uh oh!

Conversation

eps1lon commented Oct 9, 2021

Uh oh!

typescript-bot commented Oct 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

41 packages in this PR

Code Reviews

Status

Uh oh!

typescript-bot commented Oct 10, 2021

Uh oh!

typescript-bot commented Oct 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peterblazejewicz commented Oct 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eps1lon commented Oct 20, 2021

Uh oh!

peterblazejewicz left a comment

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Oct 20, 2021

Uh oh!

eps1lon commented Oct 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

typescript-bot commented Oct 10, 2021 •

edited

Loading

typescript-bot commented Oct 20, 2021 •

edited

Loading

peterblazejewicz commented Oct 20, 2021 •

edited

Loading