Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Oct 9, 2021

In preparation of #46691

@eps1lon eps1lon marked this pull request as ready for review October 9, 2021 11:20
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 9, 2021

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

36 packages in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 56399,
  "author": "eps1lon",
  "headCommitOid": "0b03b2b09b37afc317c79e10674d9639625e4dd9",
  "lastPushDate": "2021-10-09T10:12:33.000Z",
  "lastActivityDate": "2021-10-20T20:30:53.000Z",
  "mergeOfferDate": "2021-10-20T20:20:58.000Z",
  "mergeRequestDate": "2021-10-20T20:30:53.000Z",
  "mergeRequestUser": "eps1lon",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "chai-enzyme",
      "kind": "edit",
      "files": [
        {
          "path": "types/chai-enzyme/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "asvetliakov"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "emoji-mart",
      "kind": "edit",
      "files": [
        {
          "path": "types/emoji-mart/dist-es/components/emoji/emoji.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Jessidhia",
        "Nicell",
        "elviswolcott",
        "seoyunho",
        "tarrencev"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "enzyme",
      "kind": "edit",
      "files": [
        {
          "path": "types/enzyme/enzyme-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/enzyme/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "MarianPalkus",
        "NoHomey",
        "jwbay",
        "huhuanming",
        "MartynasZilinskas",
        "thovden",
        "hotell",
        "screendriver",
        "mateuszsokola",
        "braidencutforth",
        "erickzhao",
        "jtomaszewski",
        "ljharb"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "flux",
      "kind": "edit",
      "files": [
        {
          "path": "types/flux/lib/FluxContainer.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "stkb",
        "GiedriusGrabauskas"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "material-ui",
      "kind": "edit",
      "files": [
        {
          "path": "types/material-ui/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/material-ui/material-ui-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "ngbrown",
        "theigor",
        "alitaheri",
        "herrmanno",
        "DaIgeb",
        "allienna",
        "schlesingermatthias",
        "InsidersByte",
        "artyomsv",
        "dan-j",
        "minodisk",
        "samwalshnz",
        "reggino"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-adal",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-adal/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dkorolev1"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-aria-live",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-aria-live/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ajliv"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-bootstrap-date-picker",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-bootstrap-date-picker/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-bootstrap-date-picker/react-bootstrap-date-picker-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "LKay",
        "ssi-hu-antal-bodnar"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-breadcrumbs",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-breadcrumbs/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "guoyunhe",
        "matsuby"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-color",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-color/lib/components/common/ColorWrap.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-color/react-color-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "LKay",
        "markspolakovs",
        "mntdn",
        "nkgrnkgr",
        "0815Strohhut",
        "dnlfrst",
        "ericktamayo",
        "alexandercerutti"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-custom-scrollbars",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-custom-scrollbars/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-custom-scrollbars/v3/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "David-LeBlanc-git",
        "kittimiyo"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-data-grid",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-data-grid/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-data-grid/v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-data-grid/v2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "SupernaviX",
        "KieranPeat",
        "martinnov92",
        "baso53"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-fa",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-fa/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "flaub",
        "patsissons",
        "LKay"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-form",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-form/v2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "cameron-mcateer",
        "TiuSh",
        "Toliak"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-foundation",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-foundation/components/accordion.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/badge.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/breadcrumbs.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/button-group.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/button.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/callout.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/close-button.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/element.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/flex-video.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/grid.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/icon.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/label.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/media-object.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/menu.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/pagination.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/progress-bar.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/responsive.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/reveal.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/slider.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/switch.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/tabs.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/thumbnail.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/top-bar.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-foundation/components/xy-grid.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "danielearwicker"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-hyperscript",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-hyperscript/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-hyperscript/react-hyperscript-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "tock203"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-is",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-is/test/react-is-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "AviVahl",
        "christianchown",
        "eps1lon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-mailchimp-subscribe",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-mailchimp-subscribe/react-mailchimp-subscribe-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "osdiab"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-onclickoutside",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-onclickoutside/react-onclickoutside-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-onclickoutside/v5/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "LKay",
        "surgeboris",
        "NilSet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-redux",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-redux/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-redux/react-redux-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-redux/v5/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-redux/v5/react-redux-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-redux/v6/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-redux/v6/react-redux-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "tkqubo",
        "kenzierocks",
        "clayne11",
        "tansongyang",
        "nicholasboll",
        "mdibyo",
        "kallikrein",
        "val1984",
        "jrakotoharisoa",
        "apapirovski",
        "surgeboris",
        "soerenbf",
        "mrwolfz",
        "dylanvann",
        "Lazyuki",
        "kazuma1989",
        "megazazik",
        "jun-sheaf",
        "phryneas",
        "markerikson"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "react-resolver",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-resolver/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "forabi"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-router",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-router/v2/lib/withRouter.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-router/v3/lib/Router.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-router/v3/lib/withRouter.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "sergey-buturlakin",
        "mrk21",
        "vasek17",
        "ngbrown",
        "awendland",
        "KostyaEsmukov",
        "johnnyreilly",
        "LKay",
        "DovydasNavickas",
        "huy-nguyen",
        "grmiade",
        "DaIgeb",
        "egorshulga",
        "rraina",
        "t49tran",
        "8enSmith",
        "wezleytsai",
        "eps1lon",
        "HipsterBrown",
        "pawfa"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "react-slick",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-slick/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "andrewBalekha",
        "GiedriusGrabauskas",
        "r3nya",
        "Shannor"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-svg-pan-zoom",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-svg-pan-zoom/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "huy-nguyen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-table",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-table/v6/test/select-table-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "ggascoigne",
        "stramel",
        "gargroh",
        "riceboyler"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-timeout",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-timeout/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "kerwynrg"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-transition-group",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-transition-group/react-transition-group-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-transition-group/v1/react-transition-group-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "LKay",
        "Epskampie",
        "ybiquitous",
        "tu4mo",
        "bengry"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "react-twitter-auth",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-twitter-auth/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-twitter-auth/react-twitter-auth-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "paulfasola",
        "loginwashere"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-virtualized-select",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-virtualized-select/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "seansfkelley"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-virtualized",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-virtualized/dist/es/Table.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "kaoDev",
        "guntherjh",
        "wasd171",
        "szabolcsx",
        "Stevearzh",
        "mgoszcz2",
        "brandonhall",
        "sbusch",
        "azmenak"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "reactcss",
      "kind": "edit",
      "files": [
        {
          "path": "types/reactcss/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chrisgervang",
        "LKay"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "recharts",
      "kind": "edit",
      "files": [
        {
          "path": "types/recharts/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "in19farkt"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "recompose",
      "kind": "edit",
      "files": [
        {
          "path": "types/recompose/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/recompose/recompose-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "iskandersierra",
        "clayne11",
        "Pajn",
        "lucasterra",
        "brian-lives-outdoors",
        "TiuSh"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "redux-auth-wrapper",
      "kind": "edit",
      "files": [
        {
          "path": "types/redux-auth-wrapper/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/redux-auth-wrapper/redux-auth-wrapper-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/redux-auth-wrapper/v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/redux-auth-wrapper/v1/redux-auth-wrapper-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "LKay"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "redux-form",
      "kind": "edit",
      "files": [
        {
          "path": "types/redux-form/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/redux-form/lib/FormName.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/redux-form/redux-form-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/redux-form/v6/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/redux-form/v6/lib/reduxForm.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/redux-form/v6/redux-form-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/redux-form/v7/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/redux-form/v7/lib/FormName.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/redux-form/v7/lib/reduxForm.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/redux-form/v7/redux-form-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "aikoven",
        "LKay",
        "bancek",
        "tehbi4",
        "huwmartin",
        "m-b-davis",
        "ethanresnick",
        "maddijoyce",
        "smifun",
        "mshaaban088",
        "esetnik",
        "mrsekut",
        "abemedia"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "styled-components",
      "kind": "edit",
      "files": [
        {
          "path": "types/styled-components/test/index.tsx",
          "kind": "test"
        },
        {
          "path": "types/styled-components/v3/styled-components-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "Igorbek",
        "Igmat",
        "lavoaster",
        "Jessidhia",
        "jkillian",
        "eps1lon",
        "flavordaaave",
        "wagerfield",
        "Lazyuki",
        "mgoszcz2",
        "danilofuchs",
        "lifeiscontent"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "ljharb",
      "date": "2021-10-20T20:22:21.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2021-10-20T20:20:02.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 939280244,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

⚠️ There are too many reviewers for this PR change (151). Merging can only be handled by a DT maintainer.

People who would have been pinged asvetliakov Jessidhia Nicell elviswolcott seoyunho tarrencev MarianPalkus NoHomey jwbay huhuanming MartynasZilinskas thovden hotell screendriver mateuszsokola braidencutforth erickzhao jtomaszewski ljharb stkb GiedriusGrabauskas ngbrown theigor alitaheri herrmanno DaIgeb allienna schlesingermatthias InsidersByte artyomsv dan-j minodisk samwalshnz reggino dkorolev1 ajliv LKay ssi-hu-antal-bodnar guoyunhe matsuby markspolakovs mntdn nkgrnkgr 0815Strohhut dnlfrst ericktamayo alexandercerutti David-LeBlanc-git kittimiyo SupernaviX KieranPeat martinnov92 baso53 flaub patsissons cameron-mcateer TiuSh Toliak danielearwicker tock203 AviVahl christianchown osdiab surgeboris NilSet tkqubo kenzierocks clayne11 tansongyang nicholasboll mdibyo kallikrein val1984 jrakotoharisoa apapirovski soerenbf mrwolfz dylanvann Lazyuki kazuma1989 megazazik jun-sheaf phryneas markerikson forabi sergey-buturlakin mrk21 vasek17 awendland KostyaEsmukov johnnyreilly DovydasNavickas huy-nguyen grmiade egorshulga rraina t49tran 8enSmith wezleytsai HipsterBrown pawfa andrewBalekha r3nya Shannor ggascoigne stramel gargroh riceboyler kerwynrg Epskampie ybiquitous tu4mo bengry paulfasola loginwashere seansfkelley kaoDev guntherjh wasd171 szabolcsx Stevearzh mgoszcz2 brandonhall sbusch azmenak chrisgervang in19farkt iskandersierra Pajn lucasterra brian-lives-outdoors aikoven bancek tehbi4 huwmartin m-b-davis ethanresnick maddijoyce smifun mshaaban088 esetnik mrsekut abemedia Igorbek Igmat lavoaster jkillian flavordaaave wagerfield danilofuchs lifeiscontent

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Oct 20, 2021
@typescript-bot
Copy link
Contributor

Re-ping @asvetliakov, @Jessidhia, @Nicell, @elviswolcott, @Seoyunho, @tarrencev, @MarianPalkus, @NoHomey, @jwbay, @huhuanming, @MartynasZilinskas, @thovden, @Hotell, @screendriver, @mateuszsokola, @BraidenCutforth, @erickzhao, @jtomaszewski, @ljharb, @stkb, @GiedriusGrabauskas, @ngbrown, @theigor, @alitaheri, @herrmanno, @DaIgeb, @allienna, @schlesingermatthias, @InsidersByte, @artyomsv, @dan-j, @minodisk, @samwalshnz, @Reggino, @dkorolev1, @ajliv, @LKay, @ssi-hu-antal-bodnar, @guoyunhe, @matsuby, @markspolakovs, @mntdn, @nkgrnkgr, @0815Strohhut, @dnlfrst, @ErickTamayo, @alexandercerutti, @David-LeBlanc-git, @kittimiyo, @SupernaviX, @KieranPeat, @martinnov92, @baso53, @flaub, @patsissons, @cameron-mcateer, @TiuSh, @Toliak, @danielearwicker, @tock203, @AviVahl, @christianchown, @osdiab, @surgeboris, @NilSet, @tkqubo, @kenzierocks, @clayne11, @tansongyang, @nicholasboll, @mdibyo, @kallikrein, @val1984, @jrakotoharisoa, @apapirovski, @soerenbf, @mrwolfz, @dylanvann, @Lazyuki, @kazuma1989, @megazazik, @jun-sheaf, @phryneas, @markerikson, @forabi, @sergey-buturlakin, @mrk21, @vasek17, @awendland, @KostyaEsmukov, @johnnyreilly, @DovydasNavickas, @huy-nguyen, @grmiade, @egorshulga, @rraina, @t49tran, @8enSmith, @wezleytsai, @HipsterBrown, @pawfa, @andrewBalekha, @r3nya, @Shannor, @ggascoigne, @stramel, @gargroh, @riceboyler, @kerwynrg, @Epskampie, @ybiquitous, @tu4mo, @bengry, @paulfasola, @loginwashere, @seansfkelley, @kaoDev, @guntherjh, @wasd171, @szabolcsx, @Stevearzh, @mgoszcz2, @brandonhall, @sbusch, @azmenak, @chrisgervang, @in19farkt, @iskandersierra, @Pajn, @lucasterra, @brian-lives-outdoors, @aikoven, @bancek, @tehbi4, @huwmartin, @m-b-davis, @ethanresnick, @maddijoyce, @smifun, @mshaaban088, @esetnik, @mrsekut, @abemedia, @Igorbek, @Igmat, @lavoaster, @jkillian, @flavordaaave, @wagerfield, @danilofuchs, @lifeiscontent:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@huhuanming
Copy link
Contributor

LGTM

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Oct 20, 2021
@typescript-bot
Copy link
Contributor

@eps1lon: Everything looks good here. I am ready to merge this PR (at 0b03b2b) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useState isn't actually component state, and function components are still stateless :-p but sure

@eps1lon
Copy link
Collaborator Author

eps1lon commented Oct 20, 2021

Ready to merge

@typescript-bot typescript-bot merged commit 5f1a949 into DefinitelyTyped:master Oct 20, 2021
@eps1lon eps1lon deleted the fix/no-usage/SFCFactory branch October 20, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants