[react] Replace deprecated ReactType in favor of ElementType #56396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Contributor
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 15 packages in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 56396,
"author": "eps1lon",
"headCommitOid": "f8dff26b7db02133609ed8892e5dd249197c3c2b",
"lastPushDate": "2021-10-21T05:48:03.000Z",
"lastActivityDate": "2021-10-21T22:33:05.000Z",
"mergeOfferDate": "2021-10-21T22:31:51.000Z",
"mergeRequestDate": "2021-10-21T22:33:05.000Z",
"mergeRequestUser": "eps1lon",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "idyll-document",
"kind": "edit",
"files": [
{
"path": "types/idyll-document/index.d.ts",
"kind": "definition"
}
],
"owners": [
"iocat"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "react-aria-modal",
"kind": "edit",
"files": [
{
"path": "types/react-aria-modal/index.d.ts",
"kind": "definition"
}
],
"owners": [
"gabycperezdias",
"forabi",
"grgr-dkrk",
"crutchcorn"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "react-bootstrap",
"kind": "edit",
"files": [
{
"path": "types/react-bootstrap/lib/Button.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/CarouselCaption.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/Clearfix.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/Col.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/Dropdown.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/Form.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/FormControl.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/FormControlStatic.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/Grid.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/Jumbotron.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/ListGroup.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/Media.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/MediaBody.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/MediaHeading.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/MediaListItem.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/ModalBody.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/ModalFooter.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/ModalTitle.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/NavItem.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/Navbar.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/Row.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/SafeAnchor.d.ts",
"kind": "definition"
},
{
"path": "types/react-bootstrap/lib/TabContent.d.ts",
"kind": "definition"
}
],
"owners": [
"walkerburgin",
"vsiao",
"danilojrr",
"Batbold-Gansukh",
"octatone",
"chengsieuly",
"mretolaza",
"katbusch",
"vitosamson",
"LKay",
"aaronbeall",
"jrakotoharisoa",
"r3nya",
"t49tran",
"collingreen"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "react-form",
"kind": "edit",
"files": [
{
"path": "types/react-form/v2/index.d.ts",
"kind": "definition"
}
],
"owners": [
"cameron-mcateer",
"TiuSh",
"Toliak"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "react-is",
"kind": "edit",
"files": [
{
"path": "types/react-is/index.d.ts",
"kind": "definition"
}
],
"owners": [
"AviVahl",
"christianchown",
"eps1lon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "react-native",
"kind": "edit",
"files": [
{
"path": "types/react-native/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-native/v0.63/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-native/v0.64/index.d.ts",
"kind": "definition"
}
],
"owners": [
"alloy",
"huhuanming",
"iRoachie",
"timwangdev",
"kamal",
"alexdunne",
"swissmanu",
"bm-software",
"mvdam",
"esemesek",
"mrnickel",
"souvik-ghosh",
"nossbigg",
"saranshkataria",
"tykus160",
"jakebloom",
"ceyhun",
"mcmar",
"theohdv",
"TheSavior",
"romain-faust",
"bebebebebe",
"Naturalclar",
"chinesedfan",
"vtolochk",
"SychevSP",
"RageBill",
"sasurau4",
"256hz",
"doumart",
"drmas",
"akrger",
"jeremybarbet",
"ca057",
"ds300",
"natsathorn",
"connectdotz",
"TheWirv",
"alexeymolchan",
"alexbrazier",
"kuasha420",
"phvillegas",
"bdlindsay",
"eps1lon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "react-radio-group",
"kind": "edit",
"files": [
{
"path": "types/react-radio-group/index.d.ts",
"kind": "definition"
}
],
"owners": [
"jsonunger"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "react-redux-i18n",
"kind": "edit",
"files": [
{
"path": "types/react-redux-i18n/index.d.ts",
"kind": "definition"
}
],
"owners": [
"clementdevos"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "react-router",
"kind": "edit",
"files": [
{
"path": "types/react-router/v2/lib/Router.d.ts",
"kind": "definition"
}
],
"owners": [
"sergey-buturlakin",
"mrk21",
"vasek17",
"ngbrown",
"awendland",
"KostyaEsmukov",
"johnnyreilly",
"LKay",
"DovydasNavickas",
"huy-nguyen",
"grmiade",
"DaIgeb",
"egorshulga",
"rraina",
"t49tran",
"8enSmith",
"wezleytsai",
"eps1lon",
"HipsterBrown",
"pawfa"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "react-table",
"kind": "edit",
"files": [
{
"path": "types/react-table/v6/index.d.ts",
"kind": "definition"
}
],
"owners": [
"ggascoigne",
"stramel",
"gargroh",
"riceboyler"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "react-transition-group",
"kind": "edit",
"files": [
{
"path": "types/react-transition-group/TransitionGroup.d.ts",
"kind": "definition"
},
{
"path": "types/react-transition-group/v1/TransitionGroup.d.ts",
"kind": "definition"
},
{
"path": "types/react-transition-group/v1/index.d.ts",
"kind": "definition"
}
],
"owners": [
"LKay",
"Epskampie",
"ybiquitous",
"tu4mo",
"bengry"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "react-twitter-auth",
"kind": "edit",
"files": [
{
"path": "types/react-twitter-auth/index.d.ts",
"kind": "definition"
}
],
"owners": [
"paulfasola",
"loginwashere"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "react-widgets",
"kind": "edit",
"files": [
{
"path": "types/react-widgets/lib/Calendar.d.ts",
"kind": "definition"
},
{
"path": "types/react-widgets/lib/Combobox.d.ts",
"kind": "definition"
},
{
"path": "types/react-widgets/lib/DateTimePicker.d.ts",
"kind": "definition"
},
{
"path": "types/react-widgets/lib/DropdownList.d.ts",
"kind": "definition"
},
{
"path": "types/react-widgets/lib/Multiselect.d.ts",
"kind": "definition"
},
{
"path": "types/react-widgets/lib/SelectList.d.ts",
"kind": "definition"
}
],
"owners": [
"rogierschouten",
"sanyatuning",
"frodehansen2",
"r3nya",
"MBillemaz",
"georg94",
"tzarger",
"vegtelenseg",
"calebergh",
"rmckeel",
"jankalfus"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "redux-auth-wrapper",
"kind": "edit",
"files": [
{
"path": "types/redux-auth-wrapper/authWrapper.d.ts",
"kind": "definition"
},
{
"path": "types/redux-auth-wrapper/connectedAuthWrapper.d.ts",
"kind": "definition"
},
{
"path": "types/redux-auth-wrapper/index.d.ts",
"kind": "definition"
},
{
"path": "types/redux-auth-wrapper/v1/index.d.ts",
"kind": "definition"
}
],
"owners": [
"LKay"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "rheostat",
"kind": "edit",
"files": [
{
"path": "types/rheostat/index.d.ts",
"kind": "definition"
}
],
"owners": [
"SashaBayan",
"kourge",
"StefanWerW"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2021-10-21T22:31:07.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 939266064,
"ciResult": "pass"
} |
Contributor
|
Hey @eps1lon, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
Contributor
People who would have been pingediocat gabycperezdias forabi grgr-dkrk crutchcorn walkerburgin vsiao danilojrr Batbold-Gansukh octatone chengsieuly mretolaza katbusch vitosamson LKay aaronbeall jrakotoharisoa r3nya t49tran collingreen cameron-mcateer TiuSh Toliak AviVahl christianchown alloy huhuanming iRoachie timwangdev kamal alexdunne swissmanu bm-software mvdam esemesek mrnickel souvik-ghosh nossbigg saranshkataria tykus160 jakebloom ceyhun mcmar theohdv TheSavior romain-faust bebebebebe Naturalclar chinesedfan vtolochk SychevSP RageBill sasurau4 256hz doumart drmas akrger jeremybarbet ca057 ds300 natsathorn connectdotz TheWirv alexeymolchan alexbrazier kuasha420 phvillegas bdlindsay jsonunger clementdevos sergey-buturlakin mrk21 vasek17 ngbrown awendland KostyaEsmukov johnnyreilly DovydasNavickas huy-nguyen grmiade DaIgeb egorshulga rraina 8enSmith wezleytsai HipsterBrown pawfa ggascoigne stramel gargroh riceboyler Epskampie ybiquitous tu4mo bengry paulfasola loginwashere rogierschouten sanyatuning frodehansen2 MBillemaz georg94 tzarger vegtelenseg calebergh rmckeel jankalfus SashaBayan kourge StefanWerW |
Contributor
|
@eps1lon Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
Contributor
|
@eps1lon Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
rbuckton
approved these changes
Oct 21, 2021
Contributor
Collaborator
Author
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #56049 (I only used "list all references" which only looks at recently opened files in VSCode not all files in the repo)
Prepares for #46691