Replace deprecated SFC with FunctionComponent #56052
Conversation
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 56052,
"author": "eps1lon",
"headCommitOid": "028f5cb49d3a30934cfa3f15f3923288f81ab6a0",
"lastPushDate": "2021-09-29T07:17:25.000Z",
"lastActivityDate": "2021-09-29T15:38:28.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/index.d.ts",
"kind": "definition"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan",
"priyanshurav"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "priyanshurav",
"date": "2021-09-29T15:38:28.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "dimitropoulos",
"date": "2021-09-29T12:13:23.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 929924102,
"ciResult": "pass"
} |
|
🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav — please review this PR in the next few days. Be sure to explicitly select |
dimitropoulos
left a comment
There was a problem hiding this comment.
yep. thanks! you've been busy around here lately!
React.SFCwas deprecated in favor ofReact.FunctionComponent. By the time we remove the deprecated types, (hopefully) no published packages rely on that type anymore.