[react-select] Remove types by Methuselah96 · Pull Request #55978 · DefinitelyTyped/DefinitelyTyped

Methuselah96 · 2021-09-25T00:26:53Z

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run npm test <package to test>.

If removing a declaration:

If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
Delete the package's directory.
Add it to notNeededPackages.json.

typescript-bot · 2021-09-25T00:27:30Z

@Methuselah96 Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

2 packages in this PR (and infra files)

react-select (probably deleted!) — on npm, on unpkg (author is owner)
- owner-approval: @kylemh
react-virtualized-select — on npm, on unpkg
Infra files
- notNeededPackages.json

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
🕐 A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 55978,
  "author": "Methuselah96",
  "headCommitOid": "2aaf4cc889acb692c8c0233dccadfa4ee7d43ead",
  "lastPushDate": "2021-09-30T17:07:02.000Z",
  "lastActivityDate": "2021-09-30T17:28:54.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": true,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "react-select",
      "kind": "delete",
      "files": [
        {
          "path": "types/react-select/OTHER_FILES.txt",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/react-select/animated/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/async-creatable/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/async/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/base/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/creatable/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/react-select/src/Async.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/AsyncCreatable.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/Creatable.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/NonceProvider.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/Select.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/accessibility/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/animated/Input.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/animated/MultiValue.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/animated/Placeholder.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/animated/SingleValue.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/animated/ValueContainer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/animated/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/animated/transitions.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/builtins.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/components/Control.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/components/Group.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/components/Input.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/components/Menu.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/components/MultiValue.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/components/Option.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/components/Placeholder.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/components/SingleValue.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/components/containers.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/components/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/components/indicators.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/diacritics.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/filters.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/stateManager.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/styles.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/theme.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/types.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/src/utils.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/test/AtlaskitDummy.ts",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/ChronoNodeDummy.ts",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/CustomSelect.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/CustomValueContainer.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/Header.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/InputStyles.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/Placeholder.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/PropTypes/stateManager.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/SetValue.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/Tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/animatedScrollTo.ts",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/data.ts",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/AccessingInternals.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/AnimatedMulti.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/AsyncCallbacks.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/AsyncCreatable.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/AsyncMulti.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/AsyncPromises.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/BasicGrouped.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/BasicMulti.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/BasicSingle.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/ControlledMenu.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CreatableAdvanced.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CreatableGroup.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CreatableInputOnly.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CreatableMulti.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CreatableSingle.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CreateFilter.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomClearIndicator.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomControl.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomDropdownIndicator.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomFilterOptions.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomGetOptionLabel.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomGroup.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomGroupHeading.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomIndicatorSeparator.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomIndicatorsContainer.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomInput.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomIsOptionDisabled.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomLoadingIndicator.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomLoadingMessage.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomMenu.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomMenuList.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomMultiValueContainer.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomMultiValueLabel.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomMultiValueRemove.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomNoOptionsMessage.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomOption.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomPlaceholder.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomSelectContainer.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomSingleValue.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/CustomValueContainer.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/Experimental.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/FixedOptions.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/MenuPortal.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/OnMenuOpen.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/OnSelectResetsInput.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/Popout.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/StyledMulti.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/StyledSingle.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/examples/Theme.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/test/styled-components.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/react-select/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/react-select/v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/v1/lib/Option/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/v1/lib/utils/defaultMenuRenderer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-select/v1/react-select-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-select/v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/react-select/v1/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "jonfreedman",
        "Methuselah96",
        "thchia",
        "rjoonas",
        "kylemh"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-virtualized-select",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-virtualized-select/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/react-virtualized-select/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "seansfkelley"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "kylemh",
      "date": "2021-09-30T17:28:54.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "seansfkelley",
      "date": "2021-09-25T10:15:22.000Z",
      "abbrOid": "8535563"
    }
  ],
  "mainBotCommentID": 926980806,
  "ciResult": "pass"
}

typescript-bot · 2021-09-25T00:27:32Z

🔔 @jonfreedman @thchia @rjoonas @kylemh @seansfkelley — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Methuselah96 · 2021-09-25T00:29:18Z

The build is likely to fail at first since I think other packages depend on these types. :(

typescript-bot · 2021-09-25T00:31:28Z

@Methuselah96 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2021-09-25T00:39:11Z

@Methuselah96 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2021-09-25T00:46:08Z

@Methuselah96 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Methuselah96 · 2021-09-25T00:46:39Z

Waiting on microsoft/DefinitelyTyped-tools#321.

typescript-bot · 2021-09-25T00:49:39Z

@Methuselah96 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2021-09-30T17:12:22Z

@kylemh, @seansfkelley Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

typescript-bot · 2021-09-30T17:29:33Z

@seansfkelley Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[react-select] Remove types

965eb98

typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits Infrastructure labels Sep 25, 2021

typescript-bot added the The CI failed When GH Actions fails label Sep 25, 2021

Add package.json

4ef9493

typescript-bot added Edits multiple packages The CI failed When GH Actions fails and removed The CI failed When GH Actions fails labels Sep 25, 2021

Update

2e06499

typescript-bot added The CI failed When GH Actions fails and removed The CI failed When GH Actions fails labels Sep 25, 2021

Methuselah96 mentioned this pull request Sep 25, 2021

Add @types/react-select to allowPackageJsonDependencies microsoft/DefinitelyTyped-tools#321

Merged

Remove paths

8535563

typescript-bot added The CI failed When GH Actions fails and removed The CI failed When GH Actions fails labels Sep 25, 2021

typescript-bot added the Huge Change label Sep 25, 2021

seansfkelley approved these changes Sep 25, 2021

View reviewed changes

typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Sep 25, 2021

kylemh approved these changes Sep 25, 2021

View reviewed changes

Trigger Build

2aaf4cc

typescript-bot removed Owner Approved A listed owner of this package signed off on the pull request. The CI failed When GH Actions fails labels Sep 30, 2021

kylemh approved these changes Sep 30, 2021

View reviewed changes

typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Sep 30, 2021

sandersn merged commit 0f398dd into DefinitelyTyped:master Sep 30, 2021

Methuselah96 deleted the remove-react-select branch September 30, 2021 21:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[react-select] Remove types#55978

[react-select] Remove types#55978
sandersn merged 5 commits intoDefinitelyTyped:masterfrom
Methuselah96:remove-react-select

Methuselah96 commented Sep 25, 2021

Uh oh!

typescript-bot commented Sep 25, 2021 •

edited

Loading

Uh oh!

typescript-bot commented Sep 25, 2021 •

edited

Loading

Uh oh!

Methuselah96 commented Sep 25, 2021

Uh oh!

typescript-bot commented Sep 25, 2021

Uh oh!

typescript-bot commented Sep 25, 2021

Uh oh!

typescript-bot commented Sep 25, 2021

Uh oh!

Methuselah96 commented Sep 25, 2021

Uh oh!

typescript-bot commented Sep 25, 2021

Uh oh!

typescript-bot commented Sep 30, 2021

Uh oh!

typescript-bot commented Sep 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Methuselah96 commented Sep 25, 2021

Uh oh!

typescript-bot commented Sep 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2 packages in this PR (and infra files)

Code Reviews

Status

Uh oh!

typescript-bot commented Sep 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Methuselah96 commented Sep 25, 2021

Uh oh!

typescript-bot commented Sep 25, 2021

Uh oh!

typescript-bot commented Sep 25, 2021

Uh oh!

typescript-bot commented Sep 25, 2021

Uh oh!

Methuselah96 commented Sep 25, 2021

Uh oh!

typescript-bot commented Sep 25, 2021

Uh oh!

typescript-bot commented Sep 30, 2021

Uh oh!

typescript-bot commented Sep 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

typescript-bot commented Sep 25, 2021 •

edited

Loading

typescript-bot commented Sep 25, 2021 •

edited

Loading