[README] Replace invalid example links after removing ts3.6 support#55744
[README] Replace invalid example links after removing ts3.6 support#55744elibarzilay merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@retyui Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 0 packages in this PR (and infra files)
Code ReviewsThere aren't any other owners of this package, so a DT maintainer will review it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 55744,
"author": "retyui",
"headCommitOid": "85b5b501fa8e0ef4ea7a0a162633ba447da758b0",
"lastPushDate": "2021-09-13T11:31:08.000Z",
"lastActivityDate": "2021-09-13T20:56:08.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "README.cn.md",
"kind": "infrastructure"
},
{
"path": "README.it.md",
"kind": "infrastructure"
},
{
"path": "README.ja.md",
"kind": "infrastructure"
},
{
"path": "README.md",
"kind": "infrastructure"
},
{
"path": "README.pt.md",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 918102604,
"ciResult": "pass"
} |
|
🔔 @retyui — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@sandersn, @orta, @andrewbranch: I think that using explicit sha1s to avoid referring to files that can get updated is a good idea, but would be good to hear a second opinion... |
|
Seems pretty legit to me |
|
I missed this, but 3.6 is no longer supported, so the example should really use a package with |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
If removing a declaration:
notNeededPackages.json.