[soundcloud-scraper] Create soundcloud-scraper definitions.#55278
Closed
isitreallyalive wants to merge 5 commits intoDefinitelyTyped:masterfrom
isitreallyalive:soundcloud-scraper
Closed
[soundcloud-scraper] Create soundcloud-scraper definitions.#55278isitreallyalive wants to merge 5 commits intoDefinitelyTyped:masterfrom isitreallyalive:soundcloud-scraper
isitreallyalive wants to merge 5 commits intoDefinitelyTyped:masterfrom
isitreallyalive:soundcloud-scraper
Conversation
Contributor
|
@newtykins Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 55278,
"author": "newtykins",
"headCommitOid": "c170c60892fcd81233fd47d3bf3accec30f8375b",
"lastPushDate": "2021-08-21T14:05:35.000Z",
"lastActivityDate": "2021-08-21T14:05:35.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "parse-reminder",
"kind": "add",
"files": [
{
"path": "types/parse-reminder/index.d.ts",
"kind": "definition"
},
{
"path": "types/parse-reminder/parse-reminder-tests.ts",
"kind": "test"
},
{
"path": "types/parse-reminder/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.esModuleInterop`)"
},
{
"path": "types/parse-reminder/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"definitelytyped"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "soundcloud-scraper",
"kind": "add",
"files": [
{
"path": "types/soundcloud-scraper/index.d.ts",
"kind": "definition"
},
{
"path": "types/soundcloud-scraper/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/soundcloud-scraper/soundcloud-scraper-tests.ts",
"kind": "test"
},
{
"path": "types/soundcloud-scraper/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.esModuleInterop`)"
},
{
"path": "types/soundcloud-scraper/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"newtykins"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 902988924,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/c170c60892fcd81233fd47d3bf3accec30f8375b/checks?check_suite_id=3559051540"
} |
Contributor
|
🔔 @newtykins — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
Contributor
|
@newtykins The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
Contributor
|
@newtykins The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm test <package to test>.If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.