sonic-boom: mark as not needed#54756
Conversation
|
@lummish Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 2 packages in this PR (and infra files)
Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 54756,
"author": "lummish",
"headCommitOid": "e93a429f409bda566cb982c25d439ec476f6c95d",
"lastPushDate": "2021-07-26T23:17:41.000Z",
"lastActivityDate": "2021-07-26T23:45:16.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "pino",
"kind": "edit",
"files": [
{
"path": "types/pino/index.d.ts",
"kind": "definition"
},
{
"path": "types/pino/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"psnider",
"BendingBender",
"screendriver",
"paambaati",
"alferpal",
"mortiy",
"lummish",
"raoulus",
"Cooryd",
"AdamVig",
"austin-beer",
"Pegase745"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "sonic-boom",
"kind": "delete",
"files": [
{
"path": "types/sonic-boom/index.d.ts",
"kind": "definition"
},
{
"path": "types/sonic-boom/sonic-boom-tests.ts",
"kind": "test"
},
{
"path": "types/sonic-boom/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/sonic-boom/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"alferpal"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "AdamVig",
"date": "2021-07-26T23:45:16.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 887091541,
"ciResult": "pass"
} |
|
🔔 @psnider @BendingBender @screendriver @paambaati @alferpal @mortiy @raoulus @Cooryd @AdamVig @austin-beer @Pegase745 — please review this PR in the next few days. Be sure to explicitly select |
|
This appears to be breaking a few of my organization's builds, so if we could get this merged as quickly as possible that would be greatly appreciated. |
|
I just published |
|
@AdamVig thanks for the quick review! |
|
pino ones should be marked as not needed too |
Package
sonic-boomnow ships its own types. This PR removes thesonic-boomtypes and establishes a dependency frompinoto the externalsonic-boomtypings.Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If removing a declaration:
notNeededPackages.json.