Added type definitions for vite-plugin-react-svg#54276
Added type definitions for vite-plugin-react-svg#54276typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom priyanshurav:added-types-for-vite-plugin-react-svg
Conversation
|
@priyanshurav Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 54276,
"author": "priyanshurav",
"headCommitOid": "e343424727557af064df592f47eb2675885aa670",
"lastPushDate": "2021-07-06T17:25:58.000Z",
"lastActivityDate": "2021-07-09T06:36:19.000Z",
"maintainerBlessed": "Waiting for Author to Merge",
"mergeOfferDate": "2021-07-08T21:47:59.000Z",
"mergeRequestDate": "2021-07-09T06:36:19.000Z",
"mergeRequestUser": "priyanshurav",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "vite-plugin-react-svg",
"kind": "add",
"files": [
{
"path": "types/vite-plugin-react-svg/index.d.ts",
"kind": "definition"
},
{
"path": "types/vite-plugin-react-svg/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/vite-plugin-react-svg/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/vite-plugin-react-svg/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/vite-plugin-react-svg/vite-plugin-react-svg-tests.ts",
"kind": "test"
}
],
"owners": [],
"addedOwners": [
"priyanshurav"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 873627952,
"ciResult": "pass"
} |
|
🔔 @priyanshurav — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@priyanshurav The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
Ready to merge |
|
I just published |
This PR adds the type definitions for vite-plugin-react-svg
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.