Add lesgo framework type declarations#53881
Add lesgo framework type declarations#53881typescript-bot merged 9 commits intoDefinitelyTyped:masterfrom
Conversation
|
@xXLXx Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. InactiveThis PR has been inactive for 13 days — please merge or say something if there's a problem, otherwise it will be closed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 53881,
"author": "xXLXx",
"headCommitOid": "df8edcfa816c8702757156d32c98ab0833044066",
"lastPushDate": "2021-07-01T09:19:01.000Z",
"lastActivityDate": "2021-07-14T23:04:48.000Z",
"mergeOfferDate": "2021-07-01T20:38:43.000Z",
"mergeRequestDate": "2021-07-14T23:04:48.000Z",
"mergeRequestUser": "xXLXx",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "lesgo",
"kind": "add",
"files": [
{
"path": "types/lesgo/exceptions/LesgoException.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/exceptions/index.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/index.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/lesgo-tests.ts",
"kind": "test"
},
{
"path": "types/lesgo/middlewares/errorHttpResponseMiddleware.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/middlewares/httpMiddleware.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/middlewares/index.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/middlewares/normalizeHttpRequestMiddleware.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/middlewares/normalizeSQSMessageMiddleware.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/middlewares/successHttpResponseMiddleware.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/middlewares/verifyJwtMiddleware.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/lesgo/services/AuroraDbService.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/services/DynamoDbService.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/services/ElasticCacheService.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/services/ElasticsearchService.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/services/FirebaseAdminService.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/services/JWTService.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/services/LoggerService.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/services/S3Service.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/services/SQSService.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/services/index.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/services/pagination/LengthAwarePaginator.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/services/pagination/Paginator.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/tests/services/AuroraDbService.ts",
"kind": "test"
},
{
"path": "types/lesgo/tests/services/DynamoDbService.ts",
"kind": "test"
},
{
"path": "types/lesgo/tests/services/ElasticsearchService.ts",
"kind": "test"
},
{
"path": "types/lesgo/tests/services/FirebaseAdminService.ts",
"kind": "test"
},
{
"path": "types/lesgo/tests/services/JWTService.ts",
"kind": "test"
},
{
"path": "types/lesgo/tests/services/LoggerService.ts",
"kind": "test"
},
{
"path": "types/lesgo/tests/services/S3Service.ts",
"kind": "test"
},
{
"path": "types/lesgo/tests/services/SQSService.ts",
"kind": "test"
},
{
"path": "types/lesgo/tests/services/pagination/index.ts",
"kind": "test"
},
{
"path": "types/lesgo/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/lesgo/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/lesgo/utils/cache.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/db.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/dynamodb.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/elasticsearch.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/generateUid.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/getJwtSubFromAuthHeader.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/index.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/isDecimal.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/isEmail.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/isEmpty.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/logger.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/objectStore.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/prepSQLInsertParams.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/prepSQLParams.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/prepSQLUpdateParams.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/queue.d.ts",
"kind": "definition"
},
{
"path": "types/lesgo/utils/validateFields.d.ts",
"kind": "definition"
}
],
"owners": [],
"addedOwners": [
"xxlxx"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2021-07-01T20:38:07.000Z",
"isMaintainer": true
},
{
"type": "stale",
"reviewer": "DanielRosenwasser",
"date": "2021-07-01T08:58:14.000Z",
"abbrOid": "0150e60"
}
],
"mainBotCommentID": 862931803,
"ciResult": "pass"
} |
|
🔔 @idanlo — please review this PR in the next few days. Be sure to explicitly select |
|
@xXLXx The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@xXLXx The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
why do you want to change external definitions? |
|
@xXLXx The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@peterblazejewicz I was actually assuming to make use of the paths on the lesgo-test.ts as if I were in the code where this will be used. Since this is a framework people would usually use But I guess that's fine I've already changed the code so thanks! Just facing another issue now with the package.json but I think I will need to refer this first to definitely-typed-tools |
|
@xXLXx Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
|
@xXLXx The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@xXLXx One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@DanielRosenwasser, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@xXLXx: Everything looks good here. I am ready to merge this PR (at df8edcf) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
@DanielRosenwasser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
Re-ping @xXLXx / @«anyone?»: This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jul 31st (in three weeks) if this doesn't happen. (If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.) |
|
@typescript-bot I cannot merge this for some reason I believe everything is good here and please merge if you can |
|
@peterblazejewicz @DanielRosenwasser can you guys please help me merge this as this has been going for so long. There are no comments or remaining changes to be fixed here |
|
yes, no worries |
|
@xXLXx please type: into the thread, that will merge the content |
|
Ready to merge |
|
I just published |
Please fill in this template.
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run
npm test <package to test>.The package does not already provide its own types, or cannot have its
.d.tsfiles generated via--declarationIf this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
Create it with
dts-gen --dt, not by basing it on an existing project.Represents shape of module/library correctly
tslint.jsonshould contain{ "extends": "dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.