Added @types/eslint-utils#53803
Added @types/eslint-utils#53803typescript-bot merged 12 commits intoDefinitelyTyped:masterfrom JoshuaKGoldberg:eslint-utils
Conversation
|
@JoshuaKGoldberg Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 53803,
"author": "JoshuaKGoldberg",
"headCommitOid": "a6a517ba7a2ab3dd6fede29e6a3ceaa8961b54b5",
"lastPushDate": "2021-06-30T00:23:32.000Z",
"lastActivityDate": "2021-08-03T22:22:56.000Z",
"mergeOfferDate": "2021-08-03T22:04:18.000Z",
"mergeRequestDate": "2021-08-03T22:22:56.000Z",
"mergeRequestUser": "JoshuaKGoldberg",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "eslint-utils",
"kind": "add",
"files": [
{
"path": "types/eslint-utils/index.d.ts",
"kind": "definition"
},
{
"path": "types/eslint-utils/patternMatcher.d.ts",
"kind": "definition"
},
{
"path": "types/eslint-utils/referenceTracker.d.ts",
"kind": "definition"
},
{
"path": "types/eslint-utils/test/index.ts",
"kind": "test"
},
{
"path": "types/eslint-utils/test/pattern-matcher.ts",
"kind": "test"
},
{
"path": "types/eslint-utils/test/reference-tracker.ts",
"kind": "test"
},
{
"path": "types/eslint-utils/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-utils/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"JoshuaKGoldberg"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2021-06-30T17:52:16.000Z",
"isMaintainer": true
},
{
"type": "stale",
"reviewer": "MichaelDeBoey",
"date": "2021-06-22T02:01:22.000Z",
"abbrOid": "10c729d"
},
{
"type": "stale",
"reviewer": "JounQin",
"date": "2021-06-22T01:03:18.000Z",
"abbrOid": "10c729d"
},
{
"type": "stale",
"reviewer": "ota-meshi",
"date": "2021-06-22T00:50:53.000Z",
"abbrOid": "10c729d"
},
{
"type": "stale",
"reviewer": "bradzacher",
"date": "2021-06-21T23:42:34.000Z",
"abbrOid": "8cf496c"
},
{
"type": "stale",
"reviewer": "sandersn",
"date": "2021-06-18T17:48:34.000Z",
"abbrOid": "9179f50"
},
{
"type": "stale",
"reviewer": "fisker",
"date": "2021-06-17T01:49:42.000Z",
"abbrOid": "9179f50"
}
],
"mainBotCommentID": 862840325,
"ciResult": "pass"
} |
|
🔔 @JoshuaKGoldberg — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
FYI @mysticatea @fisker @MichaelDeBoey @ninevra @ota-meshi, in case any of you would like to be added to the typings file? |
ota-meshi
left a comment
There was a problem hiding this comment.
Thank you for posting this PR!
I'm not a maintainer, but I wrote some comments.
sandersn
left a comment
There was a problem hiding this comment.
I'm approving the package structure, but I know extremely little about eslint-utils so I haven't looked at the actual types.
|
I'll address the feedback first. |
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
|
@JoshuaKGoldberg The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
|
@JoshuaKGoldberg The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
|
@JoshuaKGoldberg The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@MichaelDeBoey, @JounQin, @ota-meshi, @bradzacher, @peterblazejewicz, @sandersn, @fisker Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@MichaelDeBoey, @JounQin, @ota-meshi, @bradzacher, @sandersn, @fisker Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
I will wait a bit for MichaelDeBoey to review for a bit. :) |
|
Re-ping @JoshuaKGoldberg / @«anyone?»: This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jul 30th (in three weeks) if this doesn't happen. (If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.) |
|
After a month, no one has requested merging the PR 😞. I'm going to assume that the change is not wanted after all, and will therefore close it. |
|
Oh, dangit. Can we reopen? @typescript-bot reopen? |
|
I re-opened the PR, but I'm not sure how long we have before the bot decides to close again. |
|
Ready to merge |
|
I just published |
|
Well! I was not expecting that. I guess the bot was in a good mood today. |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.