Skip to content

Added @types/eslint-utils#53803

Merged
typescript-bot merged 12 commits intoDefinitelyTyped:masterfrom
JoshuaKGoldberg:eslint-utils
Aug 3, 2021
Merged

Added @types/eslint-utils#53803
typescript-bot merged 12 commits intoDefinitelyTyped:masterfrom
JoshuaKGoldberg:eslint-utils

Conversation

@JoshuaKGoldberg
Copy link
Collaborator

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review June 17, 2021 01:18
@JoshuaKGoldberg JoshuaKGoldberg requested a review from sandersn June 17, 2021 01:19
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 17, 2021

@JoshuaKGoldberg Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 53803,
  "author": "JoshuaKGoldberg",
  "headCommitOid": "a6a517ba7a2ab3dd6fede29e6a3ceaa8961b54b5",
  "lastPushDate": "2021-06-30T00:23:32.000Z",
  "lastActivityDate": "2021-08-03T22:22:56.000Z",
  "mergeOfferDate": "2021-08-03T22:04:18.000Z",
  "mergeRequestDate": "2021-08-03T22:22:56.000Z",
  "mergeRequestUser": "JoshuaKGoldberg",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "eslint-utils",
      "kind": "add",
      "files": [
        {
          "path": "types/eslint-utils/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/eslint-utils/patternMatcher.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/eslint-utils/referenceTracker.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/eslint-utils/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/eslint-utils/test/pattern-matcher.ts",
          "kind": "test"
        },
        {
          "path": "types/eslint-utils/test/reference-tracker.ts",
          "kind": "test"
        },
        {
          "path": "types/eslint-utils/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/eslint-utils/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "JoshuaKGoldberg"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2021-06-30T17:52:16.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "MichaelDeBoey",
      "date": "2021-06-22T02:01:22.000Z",
      "abbrOid": "10c729d"
    },
    {
      "type": "stale",
      "reviewer": "JounQin",
      "date": "2021-06-22T01:03:18.000Z",
      "abbrOid": "10c729d"
    },
    {
      "type": "stale",
      "reviewer": "ota-meshi",
      "date": "2021-06-22T00:50:53.000Z",
      "abbrOid": "10c729d"
    },
    {
      "type": "stale",
      "reviewer": "bradzacher",
      "date": "2021-06-21T23:42:34.000Z",
      "abbrOid": "8cf496c"
    },
    {
      "type": "stale",
      "reviewer": "sandersn",
      "date": "2021-06-18T17:48:34.000Z",
      "abbrOid": "9179f50"
    },
    {
      "type": "stale",
      "reviewer": "fisker",
      "date": "2021-06-17T01:49:42.000Z",
      "abbrOid": "9179f50"
    }
  ],
  "mainBotCommentID": 862840325,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Jun 17, 2021
@typescript-bot
Copy link
Contributor

🔔 @JoshuaKGoldberg — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot
Copy link
Contributor

@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@JoshuaKGoldberg
Copy link
Collaborator Author

FYI @mysticatea @fisker @MichaelDeBoey @ninevra @ota-meshi, in case any of you would like to be added to the typings file?

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Jun 17, 2021
Copy link
Contributor

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for posting this PR!
I'm not a maintainer, but I wrote some comments.

Copy link
Contributor

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving the package structure, but I know extremely little about eslint-utils so I haven't looked at the actual types.

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jun 18, 2021
@JoshuaKGoldberg
Copy link
Collaborator Author

I'll address the feedback first.

Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed Maintainer Approved Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels Jun 19, 2021
@typescript-bot
Copy link
Contributor

@JoshuaKGoldberg The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed Other Approved This PR was reviewed and signed-off by a community member. labels Jun 22, 2021
@typescript-bot
Copy link
Contributor

@JoshuaKGoldberg The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed The CI failed When GH Actions fails labels Jun 30, 2021
@typescript-bot
Copy link
Contributor

@JoshuaKGoldberg The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Jun 30, 2021
@typescript-bot
Copy link
Contributor

@MichaelDeBoey, @JounQin, @ota-meshi, @bradzacher, @peterblazejewicz, @sandersn, @fisker Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jun 30, 2021
@typescript-bot
Copy link
Contributor

@MichaelDeBoey, @JounQin, @ota-meshi, @bradzacher, @sandersn, @fisker Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@JoshuaKGoldberg
Copy link
Collaborator Author

I will wait a bit for MichaelDeBoey to review for a bit. :)

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Jul 10, 2021
@typescript-bot
Copy link
Contributor

Re-ping @JoshuaKGoldberg / @«anyone?»:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jul 30th (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

@typescript-bot
Copy link
Contributor

After a month, no one has requested merging the PR 😞. I'm going to assume that the change is not wanted after all, and will therefore close it.

@JoshuaKGoldberg
Copy link
Collaborator Author

Oh, dangit. Can we reopen? @typescript-bot reopen?

@sandersn sandersn reopened this Aug 3, 2021
@sandersn
Copy link
Contributor

sandersn commented Aug 3, 2021

I re-opened the PR, but I'm not sure how long we have before the bot decides to close again.

@typescript-bot typescript-bot removed the Unmerged The author did not merge the PR when it was ready. label Aug 3, 2021
@JoshuaKGoldberg
Copy link
Collaborator Author

Ready to merge

@typescript-bot typescript-bot merged commit fad072f into DefinitelyTyped:master Aug 3, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-utils branch August 3, 2021 22:23
@typescript-bot
Copy link
Contributor

I just published @types/eslint-utils@3.0.0 to npm.

@sandersn
Copy link
Contributor

sandersn commented Aug 3, 2021

Well! I was not expecting that. I guess the bot was in a good mood today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved New Definition This PR creates a new definition package. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants