@SimonSchick Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• node — on npm, on unpkg (author is owner)

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 53566,
  "author": "SimonSchick",
  "headCommitOid": "ecc153b407b16506efb9530483aeb07b43c916e8",
  "lastPushDate": "2021-06-24T17:21:15.000Z",
  "lastActivityDate": "2021-07-01T18:57:42.000Z",
  "mergeOfferDate": "2021-07-01T16:37:07.000Z",
  "mergeRequestDate": "2021-07-01T18:57:42.000Z",
  "mergeRequestUser": "SimonSchick",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/buffer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/child_process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/fs/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/net.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/buffer.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/child_process.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/crypto.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/fs.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/http.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/net.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/stream.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "KSXGitHub",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "nguymin4",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "Ryan-Willpower",
        "peterblazejewicz",
        "addaleax",
        "JasonHK",
        "victorperin",
        "ZYSzys"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "orta",
      "date": "2021-07-01T16:36:32.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "Mesteery",
      "date": "2021-06-24T18:06:48.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "panva",
      "date": "2021-06-24T17:48:47.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "dnalborczyk",
      "date": "2021-06-04T22:47:54.000Z",
      "abbrOid": "68985fc"
    }
  ],
  "mainBotCommentID": 853504139,
  "ciResult": "pass"
}

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK @victorperin @ZYSzys — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@SimonSchick The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@SimonSchick The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@SimonSchick The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

just saw this comment in the v15.12 PR: #52776 (comment)

@SimonSchick The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@SimonSchick The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@Mesteery Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@peterblazejewicz can I get approval on this so I can move forward w/ v16?

Can we move this before it gets conflicts or otherwise becomes outdated?

Re-ping @microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @KSXGitHub, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @nguymin4, @yoursunny, @qwelias, @ExE-Boss, @Ryan-Willpower, @peterblazejewicz, @addaleax, @JasonHK, @victorperin, @ZYSzys:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@SimonSchick The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@dnalborczyk, @Mesteery Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@peterblazejewicz can I get signoff on this please <3

@SimonSchick One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

Strange, something must've gone wrong in my cherry pick since most of the commits contents are in, just not these calls, I will look into it.

@panva done, squashed into v15.14 commit, feel free to verify.
@peterblazejewicz can we please move forward?

@panva, @dnalborczyk, @Mesteery Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@dnalborczyk Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Ready to merge

I just published @types/node@15.14.0 to npm.

@SimonSchick
This commit breaks ExecSyncOptions. Specifically, the windowsHide property is no longer available in ExecSyncOptions.

For example:

childProcess.execSync("git status", { encoding: "utf8", windowsHide: true })

Results in:

No overload matches this call. Overload 1 of 4, '(command: string, options?: ExecSyncOptionsWithStringEncoding | undefined): string', gave the following error. Argument of type '{ encoding: "utf8"; windowsHide: boolean; }' is not assignable to parameter of type 'ExecSyncOptionsWithStringEncoding'. Object literal may only specify known properties, but 'windowsHide' does not exist in type 'ExecSyncOptionsWithStringEncoding'.

Cause:

Was: ExecSyncOptions extends CommonOptions → contains windowsHide
Now: ExecSyncOptions extends CommonExecOptions extends ProcessEnvOptions → Does not contain windowsHide

@SimonSchick
I've verified your #54400 fix in both @types/node@15.14.2 and @types/node@16.3.1. Thanks for your help 🙏.