@SevenOutman Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• testing-library__jest-dom — on npm, on unpkg
  • owner-approval: @gnapse

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes in this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 53505,
  "author": "SevenOutman",
  "headCommitOid": "14882a81536b67e6160aab3eef4ddbdf77469569",
  "lastPushDate": "2021-06-08T00:42:36.000Z",
  "lastActivityDate": "2021-06-08T19:23:01.000Z",
  "mergeOfferDate": "2021-06-08T17:04:04.000Z",
  "mergeRequestDate": "2021-06-08T19:23:01.000Z",
  "mergeRequestUser": "SevenOutman",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "testing-library__jest-dom",
      "kind": "edit",
      "files": [
        {
          "path": "types/testing-library__jest-dom/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/testing-library__jest-dom/test/testing-library__jest-dom-global-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "gnapse",
        "jgoz",
        "smacpherson64"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "amcasey",
      "date": "2021-06-08T17:03:28.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "gnapse",
      "date": "2021-06-08T01:25:38.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 850985208,
  "ciResult": "pass"
}

🔔 @gnapse @jgoz @smacpherson64 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@SevenOutman One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@gnapse Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

because this matcher is not yet merged in jest-dom.

Sure, please review this PR testing-library/jest-dom#370 when you have time.

@gnapse I just updated the definition version to newly released 5.13 which included this new matcher.

@gnapse Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@gnapse, @amcasey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@amcasey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Ready to merge

I just published @types/testing-library__jest-dom@5.13.0 to npm.